Fix #624 - Change PublicKeyCredential.clientExtensionResults to an operation #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… operation The attribute `clientExtensionResults` is a typedef of `record<DOMString, any>`. The WebIDL spec says "Records must not be used as the type of an attribute or constant", so this is not legal. This commit changes the attribute `clientExtensionResults` into an operation `getClientExtensionResults()`.
jcjones
force-pushed
the
624-clientExtensionResults
branch
from
fa5c155
to
355f1ca
Compare
AngeloKai
approved these changes
Oct 12, 2017
|
@jyasskin @equalsJeffH please review as we need to get this one in ASAP |
bzbarsky
reviewed
Oct 18, 2017
| @@ -2761,7 +2753,7 @@ Supported [=client extensions=] are recorded as a dictionary in the [=client dat | |||
| {{CollectedClientData/clientExtensions}}. For each such extension, the client adds an entry to this dictionary with the | |||
| [=extension identifier=] as the key, and the extension's [=client extension input=] as the value. | |||
|
|
|||
| Likewise, the [=client extension outputs=] are represented as a dictionary in the {{PublicKeyCredential/clientExtensionResults}} | |||
| Likewise, the [=client extension outputs=] are represented as a dictionary in the result of {{PublicKeyCredential/getClientExtensionResults()}} | |||
There was a problem hiding this comment.
They are represented as a record, not a dictionary...
This was referenced Oct 18, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute
clientExtensionResultsis a typedef ofrecord<DOMString, any>.The WebIDL spec says "Records must not be used as the type of an attribute
or constant", so this is not legal.
This commit changes the attribute
clientExtensionResultsinto an operationgetClientExtensionResults().This resolves #624.
Preview | Diff