-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve linking errors for WD-07 publication #703
Conversation
…urce]](origin, options, sameOriginWithAncestors)
Can one of the reviewers I nominated please double check in case the change is not right? Anyone reviewing it would be fine. |
I agree with removing the link for The I still show one linking error with an updated bikeshed, checking on it:
|
index.bs
Outdated
@@ -986,7 +986,8 @@ for="PublicKeyCredential" method>\[[CollectFromCredentialStore]](origin, options | |||
|
|||
<div link-for-hint="PublicKeyCredential/[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)"> | |||
|
|||
This [=internal method=] accepts three arguments: | |||
{{PublicKeyCredential}}'s [=interface object=]'s implementation of the | |||
<dfn for="PublicKeyCredential" method>\[[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors)</dfn> [=internal method=] accepts three arguments: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's please not put this long unnecessary sentence back and find another place for the <dfn>. apologies for not cleaning this up myself earlier... am looking into it....
@AngeloKai -- thx for working on fixing these linking errors, my apologies for not having done so -- the "AttestationNotPrivateError" one is fine, the other change I'd rather not make (https://github.com/w3c/webauthn/pull/703/files#r154392024) -- am looking into a workaround... |
@jcjones -- wrt #703 (comment) -- fwiw, i do not get any errors with the present state of the anglokai/webauthn:master branch when building using cloud bikeshed. |
Ok, I have an edit on the |
@AngeloKai sez that my pushing directly to https://github.com/AngeloKai/webauthn:master at this time is inconvenient, so here's a hist of the latest commits in that branch including mine in my local clone:
and here's the diff of what I propose we change, between the two most-recent commits shown above:
|
shall we close this PR ? |
doh, nevermind. it's merged already, had neglected to refresh the page |
When you test, please make sure you have an updated copy of bikeshed.
This resolves the two remaining linking errors:
Preview | Diff