#420: Add note on why authenticator attachment is used only in create() #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equalsJeffH
approved these changes
Dec 6, 2017
There was a problem hiding this comment.
This looks fine to me per the discussion over in Issue #420. Let's merge this.
|
Reviewed: #708 (review) |
nadalin
requested review from
akshayku and
agl
and removed request for
christiaanbrand
|
(I was asked to review this during last week's call. Looks good to me.) |
|
Can someone explain to me how an RP who only wants to talk to, lets say, platform authenticators can achieve this without attachment option in assertion? |
akshayku
approved these changes
Dec 20, 2017
WebAuthnBot
pushed a commit
that referenced
this pull request
Dec 20, 2017
…ise used only in create() (#708)
|
discussed @akshayku's comment on the 20-Dec-2017 call and obtained consensus to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #420.