Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 711 identifier internal slot contains credID #729

Merged
merged 1 commit into from
Dec 20, 2017
Merged

fix 711 identifier internal slot contains credID #729

merged 1 commit into from
Dec 20, 2017

Conversation

equalsJeffH
Copy link
Contributor

@equalsJeffH equalsJeffH commented Dec 19, 2017 •
edited by pr-preview bot
Loading

fixes #711

Preview | Diff

@equalsJeffH equalsJeffH added this to the CR milestone Dec 19, 2017
@equalsJeffH equalsJeffH self-assigned this Dec 19, 2017
emlun
emlun approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rlin1
Copy link
Contributor

rlin1 commented Dec 20, 2017

LGTM

akshayku
akshayku approved these changes Dec 20, 2017
View reviewed changes
Copy link
Contributor

@akshayku akshayku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@equalsJeffH
Copy link
Contributor Author

decided on 20-Dec-2017 call to merge this

@equalsJeffH equalsJeffH merged commit 06af8bc into master Dec 20, 2017
WebAuthnBot pushed a commit that referenced this pull request Dec 20, 2017
Built by Travis-CI: 06af8bc fix 711 identifier internal slot contains…
22b11ae 
… credID (#729)
@emlun emlun deleted the jeffh-fix-711-identifier-slot-contains-credID branch June 12, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayku akshayku akshayku approved these changes

@selfissued selfissued selfissued approved these changes

@emlun emlun emlun approved these changes

@jcjones jcjones Awaiting requested review from jcjones

Assignees

@equalsJeffH equalsJeffH

Labels
type:editorial type:technical
Projects
None yet
Milestone
Last Working Draft
Development

Successfully merging this pull request may close these issues.

[[identifier]]'s explanation ought to link to [=credential ID=]
6 participants
@equalsJeffH @rlin1 @emlun @selfissued @akshayku @nadalin