Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDDL to reflect packed, self-attestation. #751

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

agl
Copy link
Contributor

@agl agl commented Jan 17, 2018

The verification process for the packed attestation format deals with a
case where both x5c and ecdaaKeyId elements are absent, but the CDDL
doesn't reflect that possibility.


Preview | Diff

The verification process for the packed attestation format deals with a
case where both `x5c` and `ecdaaKeyId` elements are absent, but the CDDL
doesn't reflect that possibility.
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thx! LGTM.

@nadalin
Copy link
Contributor

nadalin commented Feb 5, 2018

@agl Please merge

@agl agl merged commit 72958fe into w3c:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants