Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial changes from PR #718 #752

Merged
merged 4 commits into from
Feb 6, 2018
Merged

Editorial changes from PR #718 #752

merged 4 commits into from
Feb 6, 2018

Conversation

emlun
Copy link
Member

@emlun emlun commented Jan 17, 2018

These are the editorial changes from #718. Reviewing each commit on its own is probably easier than all together.

Many of the changes are in response to a review comment: #718 (review)


Preview | Diff

@emlun emlun self-assigned this Jan 17, 2018
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@equalsJeffH equalsJeffH added this to the CR milestone Feb 5, 2018
@nadalin
Copy link
Contributor

nadalin commented Feb 5, 2018

@emlun Please merge

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@emlun emlun merged commit 573a03a into master Feb 6, 2018
@emlun emlun deleted the pr-718-editorial-changes branch February 6, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants