Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-hardcode list item numbers #754

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Un-hardcode list item numbers #754

merged 1 commit into from
Jan 22, 2018

Conversation

emlun
Copy link
Member

@emlun emlun commented Jan 22, 2018

Except for two cases where the preceding text explicitly states that the
list has two elements.

This will ease both editing and review as there won't be number changes clobbering the diffs.


Preview | Diff

Except for two cases where the preceding text explicitly states that the
list has two elements.
@emlun emlun added this to the CR milestone Jan 22, 2018
@emlun emlun self-assigned this Jan 22, 2018
@emlun emlun requested a review from jcjones January 22, 2018 17:41
Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@emlun
Copy link
Member Author

emlun commented Jan 22, 2018

Thanks @selfissued! Since this is purely editorial, I'll go ahead and merge.

@emlun emlun merged commit 1e77b42 into master Jan 22, 2018
@emlun emlun deleted the unhardcode-list-numbers branch January 22, 2018 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants