Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #610 privacy CA now known as attestation CA #762

Merged
merged 5 commits into from
Jan 31, 2018

Conversation

equalsJeffH
Copy link
Contributor

@equalsJeffH equalsJeffH commented Jan 24, 2018

fixes #610

[ in case anyone noticed (unlikely, I realize): the branch name this PR is based on is incorrect, it should be jeffh-fix-610-privacy-ca-cites, but oh well it is not. too much trouble to change it at this point...]


Preview | Diff

@equalsJeffH equalsJeffH added type:editorial subtype:impl-cons privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. subtype:attestation labels Jan 24, 2018
@equalsJeffH equalsJeffH added this to the CR milestone Jan 24, 2018
@equalsJeffH equalsJeffH self-assigned this Jan 24, 2018
index.bs Outdated
:: In this case, an [=authenticator=] is based on a Trusted Platform Module (TPM) and holds an authenticator-specific
"endorsement key" (EK). This key is used to securely communicate with a trusted third party, the [=Attestation CA=]
[[!TCG-CMCProfile-AIKCertEnroll]] (formerly known as a "Privacy CA"). The [=authenticator=] can generate multiple
attestation identity key pairs (AIK) and requests an [=Attestation CA=] to issue an attestation identity certificate (AIK)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the latter AIK here be AIC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"AIC" is not used in [[!TCG-CMCProfile-AIKCertEnroll]], so I'm thinking not....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I just wanted to thought it looked strange that the same acronym was used for two different things.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, you did identify a problem -- should be using term "AIK certificate" here.

index.bs Outdated
[[!TCG-CMCProfile-AIKCertEnroll]] (formerly known as a "Privacy CA"). The [=authenticator=] can generate multiple
attestation identity key pairs (AIK) and requests an [=Attestation CA=] to issue an attestation identity certificate (AIK)
for each. Using this approach, such an [=authenticator=] can limit the exposure of the EK (which is a global correlation
handle) to Attestation CA(s). AIKs can be requested for each [=authenticator=]-generated [=public key credential=]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking usage of AIK here is nominally correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks better!

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after fixing the incorrect article.

index.bs Outdated
@@ -1746,14 +1746,15 @@ during credential generation.
* <dfn>none</dfn> - indicates that the [=[RP]=] is not interested in [=authenticator=] [=attestation=].
The client MAY replace the [=AAGUID=] and [=attestation statement=] generated
by the authenticator with meaningless client-generated values. For example, in order to avoid having to obtain
[=user consent=] to relay uniquely identifying information to the [=[RP]=], or to save a roundtrip to a Privacy CA.
[=user consent=] to relay uniquely identifying information to the [=[RP]=], or to save a roundtrip to a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "a" to "an"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, see 0cbccd0

@jcjones
Copy link
Contributor

jcjones commented Jan 24, 2018

It looks like the CI build didn't run... is Anonymization CA defined anywhere? I don't see it.

@equalsJeffH
Copy link
Contributor Author

@jcjones

is Anonymization CA defined anywhere? I don't see it.

see https://github.com/w3c/webauthn/pull/762/files#diff-ec9cfa5f3f35ec1f84feb2e59686c34dR4448

It looks like the CI build didn't run...

it appears it was that "used only once" allowCredentialDescriptorList warning that we fixed earlier today. now fixed in master and this branch. looks like travisCI is now running....

thx for headzup :)

@equalsJeffH
Copy link
Contributor Author

equalsJeffH commented Jan 24, 2018

bummer.

FATAL ERROR: Couldn't find 'TCG-CMCProfile-AIKCertEnroll' in bibliography data.

I don't know what's going.....wait...

https://www.specref.org/?q=TCG-CMCProfile-AIKCertEnroll

....shows that the reference is in specref.org...so i think this error is a hint that we need to update our cached repo-side build stuff such that we have the latest specref data ? @jcjones ? :)

@jcjones
Copy link
Contributor

jcjones commented Jan 25, 2018

@equalsJeffH: I've updated the spec-data, but to tell in the PR we'd need to rebase the PR, which I can't do from this interface.

@equalsJeffH
Copy link
Contributor Author

equalsJeffH commented Jan 25, 2018

@jcjones: I've updated the spec-data...
thanks! I merged-from-master cb6ba29 ...waiting to see if the travis build is successful...
...seems it was successful :) thx again!

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge

@equalsJeffH
Copy link
Contributor Author

equalsJeffH commented Jan 30, 2018

it would be nice to get an OK from Chrome folk (before merging) since I invented the "anonymization CA" name for the entity they have so far been refering to as a "Privacy CA" (which would end up being confusing since that name was originally used by TCG specs for an entity that behaves somewhat differently and now is itself renamed to "Attestation CA")

@agl
Copy link
Contributor

agl commented Jan 30, 2018

If we end up using a privacy CA, we're probably going to call it a privacy CA irrespective of whatever is in the spec. I think the term is pretty well established for "thing that checks a specific certificate and issues a general one saying that it checked it". I don't see that we need another term for the same thing.

@equalsJeffH
Copy link
Contributor Author

equalsJeffH commented Jan 30, 2018

@agl wrote:

If we end up using a privacy CA, we're probably going to call it a privacy CA irrespective of whatever is in the spec.

Thx, understood. I prefer to keep these terms separate (i.e., clearly delineated) in the spec, and y'all can call such functionality whatever you want, if it is materialized.

@selfissued
Copy link
Contributor

Agreed. I think this is ready to merge.

@equalsJeffH equalsJeffH merged commit 0f4cfe4 into master Jan 31, 2018
WebAuthnBot pushed a commit that referenced this pull request Jan 31, 2018
@emlun emlun deleted the jeffh-fix-647-privacy-ca-cites branch June 12, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. subtype:attestation subtype:impl-cons type:editorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per TCG: "privacy CA" is now "Attestation CA"
5 participants