Security Considerations for Unsigned Credential ID #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
requested changes
Jan 26, 2018
index.bs
Outdated
|
|
||
| The credential ID is not signed. | ||
| This is not a problem because all that would happen if an authticator returns |
index.bs
Outdated
|
|
||
| The credential ID is not signed. | ||
| This is not a problem because all that would happen if an authticator returns | ||
| the wrong crednetial ID is that the RP will not look up the correct |
There was a problem hiding this comment.
Typo: crednetial
Suggest: RP -> [=[RP] =]
There was a problem hiding this comment.
I think a more interesting case to point out is if a MitM were to manipulate the credential ID (the conclusion is the same), so I would probably write this as something like "[...] if an authenticator returns the wrong credential ID, or if an attacker intercepts and manipulates the credential ID, is that the RP [...]"
|
Also, perhaps link some of the terms throughout? I can make a PR of that into this PR if you can't run bikeshed. |
|
@emlun if you can create a PR into my PR addressing the issues you raise that would great. Then I could apply it in my morning and merge the combination into master. |
WebAuthnBot
pushed a commit
that referenced
this pull request
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394
Preview | Diff