Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #763 untangled: Add consideration of browser permissions framework for extension processing #771

Merged
merged 6 commits into from
Feb 6, 2018

Conversation

emlun
Copy link
Member

@emlun emlun commented Jan 31, 2018

This is what I believe to be the intended changes of #763, with untangled Git history. @gmandyam please verify.


Preview | Diff

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@gmandyam
Copy link

@emlun

Thanks for doing this. It works for me. I had this section under Sec Cons, but Privacy Cons seems to be more appropriate.

Approved.

@emlun
Copy link
Member Author

emlun commented Jan 31, 2018

Oops, that was an oversight on my part. I think its original placement under Sec Cons is more appropriate, do you object to moving it there?

@gmandyam
Copy link

@emlun

No - please do so.

@equalsJeffH
Copy link
Contributor

fixes #133

Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo modest suggested wordsmithing. Thx!

index.bs Outdated

## Browser Permissions Framework and Extensions ## {#browser-permissions-framework-extensions}

The Web Authentication API should leverage the browser permissions framework as much as possible when obtaining user permissions for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest:
s/The //
s/ API / API implementations /

index.bs Outdated
## Browser Permissions Framework and Extensions ## {#browser-permissions-framework-extensions}

The Web Authentication API should leverage the browser permissions framework as much as possible when obtaining user permissions for
certain extensions. An example is the location extension (see [[#sctn-location-extension]]), which should make use of the existing browser permissions framework for the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest:
s/ which / implementations of which /

@emlun
Copy link
Member Author

emlun commented Feb 2, 2018

@gmandyam Will you continue the work on this?

@gmandyam
Copy link

gmandyam commented Feb 2, 2018

@emlun

It would be easier (for me) if you incorporated the editorial changes requested by @equalsJeffH. After that, I think we can merge this PR. Afterwards, I can address additional comments that will come up during CR wide review. Thanks.

@emlun emlun self-assigned this Feb 5, 2018
@emlun
Copy link
Member Author

emlun commented Feb 5, 2018

Since @selfissued, @equalsJeffH and @gmandyam have all approved this PR, I'll merge it if I see no objections before 2018-02-06T10:00+01:00.

@equalsJeffH equalsJeffH added this to the CR milestone Feb 5, 2018
@nadalin
Copy link
Contributor

nadalin commented Feb 5, 2018

@emlun Can you merge ?

@selfissued selfissued merged commit 99766e0 into master Feb 6, 2018
@emlun emlun deleted the pr-763-untangled branch February 6, 2018 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants