-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR #763 untangled: Add consideration of browser permissions framework for extension processing #771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this
Thanks for doing this. It works for me. I had this section under Sec Cons, but Privacy Cons seems to be more appropriate. Approved. |
Oops, that was an oversight on my part. I think its original placement under Sec Cons is more appropriate, do you object to moving it there? |
No - please do so. |
…urity Considerations section
fixes #133 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo modest suggested wordsmithing. Thx!
index.bs
Outdated
|
||
## Browser Permissions Framework and Extensions ## {#browser-permissions-framework-extensions} | ||
|
||
The Web Authentication API should leverage the browser permissions framework as much as possible when obtaining user permissions for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest:
s/The //
s/ API / API implementations /
index.bs
Outdated
## Browser Permissions Framework and Extensions ## {#browser-permissions-framework-extensions} | ||
|
||
The Web Authentication API should leverage the browser permissions framework as much as possible when obtaining user permissions for | ||
certain extensions. An example is the location extension (see [[#sctn-location-extension]]), which should make use of the existing browser permissions framework for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest:
s/ which / implementations of which /
@gmandyam Will you continue the work on this? |
It would be easier (for me) if you incorporated the editorial changes requested by @equalsJeffH. After that, I think we can merge this PR. Afterwards, I can address additional comments that will come up during CR wide review. Thanks. |
Since @selfissued, @equalsJeffH and @gmandyam have all approved this PR, I'll merge it if I see no objections before 2018-02-06T10:00+01:00. |
@emlun Can you merge ? |
This is what I believe to be the intended changes of #763, with untangled Git history. @gmandyam please verify.
Preview | Diff