fix 745: remove self attstn from U2F attstn format #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agl
reviewed
Feb 7, 2018
index.bs
Outdated
| @@ -3365,7 +3365,7 @@ This attestation statement format is used with FIDO U2F authenticators using the | |||
| :: fido-u2f | |||
|
|
|||
| : Attestation types supported | |||
| :: [=Basic Attestation=], [=Self Attestation=], [=Attestation CA=] | |||
| :: [=Basic=], [=AttCA=] | |||
There was a problem hiding this comment.
Is AttCA a typo? (I see other references to [=Attestation CA=] in the file, but none to AttCA.)
There was a problem hiding this comment.
Oh, perhaps it works in light of this change.
There was a problem hiding this comment.
yeah that's why i suggest merging pr #746 before this one, in the OP #781 (comment)
agl
approved these changes
Feb 7, 2018
index.bs
Outdated
| @@ -3365,7 +3365,7 @@ This attestation statement format is used with FIDO U2F authenticators using the | |||
| :: fido-u2f | |||
|
|
|||
| : Attestation types supported | |||
| :: [=Basic Attestation=], [=Self Attestation=], [=Attestation CA=] | |||
| :: [=Basic=], [=AttCA=] | |||
There was a problem hiding this comment.
Oh, perhaps it works in light of this change.
|
@emlun Please review |
|
@equalsJeffH Can you merge ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #745, related to PR #746 (merge latter before this one)
Preview | Diff