Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTAP2 definition fix #783

Merged
merged 2 commits into from
Feb 7, 2018
Merged

CTAP2 definition fix #783

merged 2 commits into from
Feb 7, 2018

Conversation

apowers313
Copy link
Contributor

@apowers313 apowers313 commented Feb 7, 2018 •
edited by pr-preview bot
Loading

Fixes:

  • Changed "CTAP Canonical CBOR" to "CTAP2 Canonical CBOR" to stay in step with proper definition of CTAP1 & CTAP2
  • CTAP2 definition will link to the correct section in the next version of the spec

Bonus fixes:

  • Added biblio-reference for Geolocation spec, ensuring that it links properly and actually shows up in bibliography
  • Added definition for Coordinates, ensuring that all occurrences link to the Geolocation spec correctly, including in the IDL block

Preview | Diff

@apowers313 apowers313 mentioned this pull request Feb 7, 2018
Closed
@equalsJeffH equalsJeffH self-requested a review February 7, 2018 17:42
equalsJeffH
equalsJeffH approved these changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@equalsJeffH equalsJeffH added this to the CR milestone Feb 7, 2018
@equalsJeffH equalsJeffH merged commit 5633790 into w3c:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equalsJeffH equalsJeffH equalsJeffH approved these changes

@selfissued selfissued selfissued approved these changes

Assignees

@apowers313 apowers313

Labels
type:editorial
Projects
None yet
Milestone
Last Working Draft
Development

Successfully merging this pull request may close these issues.
3 participants
@apowers313 @equalsJeffH @selfissued