Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling and grammar corrections #815

Merged
merged 4 commits into from
Feb 23, 2018

Conversation

selfissued
Copy link
Contributor

@selfissued selfissued commented Feb 22, 2018

Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I found a few more a/an errors, will submit cross-PR shortly.

index.bs Outdated
@@ -3374,10 +3375,10 @@ the attestation=] is consistent with the fields of the attestation certificate's
:: Let |authenticatorData| denote the [=authenticator data for the attestation=], and let |clientDataHash| denote the
[=hash of the serialized client data=].

Request an Android Key Attestation by calling "keyStore.getCertificateChain(myKeyUUID)") providing |clientDataHash| as the
Request an Android Key Attestation by calling "keyStore.getCertificateChain(myKeyUUID)" providing |clientDataHash| as the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use <code> instead of quotes for the keyStore code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably so - I'll make the change

@emlun
Copy link
Member

emlun commented Feb 22, 2018

A few more a/an errors: selfissued#5

For future reference, here are two vim regular expressions I used to find them. They detect a lot of false positives ("u" words in particular...), but should hopefully have few or no false negatives except for aliases whose expansion changes the initial letter.

  • Find (possibly) incorrect "an"s: /\v(^|[^a-zA-Z])an\_s[^a-zA-Z]*[qwrtyupsdfghjklzxcvbnmQWRTYUPSDFGHJKLZXCVBNM]
  • Find (possibly) incorrect "a"s: /\v(^|[^a-zA-Z])a\_s[^a-zA-Z]*[aeyuioAEYUIO]

@selfissued selfissued merged commit 5c3054f into w3c:master Feb 23, 2018
kpaulh pushed a commit to kpaulh/webauthn that referenced this pull request Apr 6, 2018
* Spelling and grammar corrections

* Fix a few more a/an errors

* Apply <code>...</code> as suggested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants