Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Subject-C type from UTF8String to PrintableString #819

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

emlun
Copy link
Member

@emlun emlun commented Feb 23, 2018

See RFC 5280 page 115: https://tools.ietf.org/html/rfc5280#page-115

This fixes #818.

@emlun
Copy link
Member Author

emlun commented Feb 23, 2018

I suggest @agl reviews this since he submitted #769.

Copy link
Contributor

@agl agl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this.

@emlun
Copy link
Member Author

emlun commented Feb 23, 2018

Thanks @agl! Credit for catching it goes to @klali. :)

@selfissued selfissued merged commit 567ae6d into w3c:master Feb 23, 2018
WebAuthnBot pushed a commit that referenced this pull request Feb 23, 2018
@emlun emlun deleted the issue-818-subject-c-type branch February 26, 2018 10:18
kpaulh pushed a commit to kpaulh/webauthn that referenced this pull request Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subject-C type in packed cert requirements is incorrect
3 participants