-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vestigial reference to CollectedClientData/clientExtensions #835
Remove vestigial reference to CollectedClientData/clientExtensions #835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text now reads:
The client extension input for the extension is used an input to this client processing. For each supported client extension, the client adds an entry to this dictionary with the extension identifier as the key, and the extension’s client extension input as the value.
However, "this dictionary" is now undefined. Actually, the whole second sentence is now outdated because the client no longer records the client extension inputs in the response. Perhaps this instead needs to say that the RP adds the input values to the extensions
parameter?
By the way, there's also an unrelated pre-existing typo in the first sentence: "is used an input"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree w/@emlun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Mike!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Note to emlun: in the respective processing rules we say "Let clientExtensions be a new map and let authenticatorExtensions be a new map." etc. |
…3c#835) Merging per decision on 14-Mar-18 call
Fixes #828
Preview | Diff