Define the browsingContext.close command

[juliandescottes]

Fixes #170.

This adds the definition for browsingContext.close. I copied and modified existing browsingContext commands and tried to match https://w3c.github.io/webdriver/#close-window.

Opening the PR to get a first round of feedback, thanks in advance!
cc @jgraham @whimboo

---

Preview | Diff

[juliandescottes]

Also for now I left out the question about what to do when closing the last window.
I would first like to clean up the "straightforward" part of the PR from obvious mistakes before diving into this question.

[juliandescottes]

Thanks for getting to the review so quickly @jgraham!

[whimboo]

I had a quick look and in general it looks fine. Still two comments inline which would require an update.

[whimboo]

Also for now I left out the question about what to do when closing the last window. I would first like to clean up the "straightforward" part of the PR from obvious mistakes before diving into this question.

Thanks for the updates @juliandescottes. So I assume this is left to do then.

Btw. this fixes issue #170.

[juliandescottes]

Also for now I left out the question about what to do when closing the last window. I would first like to clean up the "straightforward" part of the PR from obvious mistakes before diving into this question.

Thanks for the updates @juliandescottes. So I assume this is left to do then.

Btw. this fixes issue #170.

Yes, I'll bring it up during our meeting and will update here afterwards. Also added the reference to #170 in the description, thanks for the reminder!

[juliandescottes]

FWIW, Issue(w3c/webdriver-bidi#170) seems to generate a valid link

[juliandescottes]

@foolip can you re-review since you reviewed the latest version before the update :) Thanks!

[foolip]

@jgraham do you want to review again?

Comments are addressed