-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make innerText locator work with non-element nodes #705
Conversation
Co-authored-by: Maksim Sadym <69349599+sadym-chromium@users.noreply.github.com>
@OrKoN do we have any blockers for this PR? |
@sadym-chromium Mozilla's review I believe |
SHA: 34104f2 Reason: push, by OrKoN Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There is still an open question how to deal with request with document as a start node, and maxDepth equals zero:
As long as document does not have
|
@sadym-chromium I think #2 would be something I would expect. I.e., the document does match and the max depth is 0, therefore, no recursive calls. |
Currently spec says in this case the search should go to all the depth. |
Option 2: web-platform-tests/wpt#46346 |
I feel like users are probably going to expect not decreasing depth on document elements i.e. passing in |
@OrKoN are you going to create / update wpt tests for this change? |
Here is the spec change for this option: #713 |
@whimboo @sadym-chromium will update it after the remaining issue is resolved |
…s` (#2218) * w3c/webdriver-bidi#705 * w3c/webdriver-bidi#713 * web-platform-tests/wpt#46345 --------- Signed-off-by: Browser Automation Bot <browser-automation-bot@google.com> Co-authored-by: Browser Automation Bot <browser-automation-bot@google.com>
This PR changes the innerText locator to handle non-Element nodes correctly.
Preview | Diff