-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for default-initialized example #367
Conversation
Hi, thank you for the PR!
I think this is why the test is failing, could you explain the reason you did it? And I'm not sure why we need another test as #338 added one with |
Well, for one, it's a different context; the test in #338 is a member with default value, not a default value of a parameter to an operator. The AST fails to generate at all with the Sorry if this reply is sloppy, I'm on my phone :) |
In case it's not clear in the description: |
Ah, definitely worth then 👍
What did you do to generate AST? @marcoscaceres Do you have an idea why Travis is failing to start again? I thought the migration to service to app fixed it, but seems not 🤔 PS: The wierd |
Having a look at Travis... |
Hmm... I don't have rights to access the settings... but what's more strange is that the other PRs are all fine. |
I think Travis has a problem only with PRs from forks. |
Yeah, I was thinking the same... maybe just merge and hope for the best 🙊😂 |
Thanks! |
From https://heycam.github.io/webidl/#idl-operations
Test case currently fails (expected to, as seems to be the cause of w3c/webref#34)
Not intending to land this PR without the fix, but it's a step in the right direction.
default.json
content was generated by temporarily omitting the= {}
syntax, and JSON.stringify'ing the AST.