Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup GitHub Actions #386

Merged
merged 4 commits into from
Aug 21, 2019
Merged

Setup GitHub Actions #386

merged 4 commits into from
Aug 21, 2019

Conversation

saschanaz
Copy link
Member

🎉

@saschanaz
Copy link
Member Author

The documentation is here but not sure how to mark the actions as "Required".

marcoscaceres
marcoscaceres approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we try this out for a little while and then delete the travis file?

@saschanaz
Copy link
Member Author

saschanaz commented Aug 21, 2019 •
edited
Loading

Okay, the nvm syntax doesn't work. Did GitHub just invent their own node selector syntax? 🙄

@saschanaz
Copy link
Member Author

It's tracked by actions/setup-node#26, will apply it when it's done.

@marcoscaceres
Copy link
Member

It's tracked by actions/setup-node#26, will apply it when it's done.

Sounds good.

@saschanaz saschanaz merged commit 551e751 into gh-pages Aug 21, 2019
@saschanaz saschanaz deleted the saschanaz-patch-1 branch August 21, 2019 07:55
@saschanaz saschanaz mentioned this pull request Aug 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saschanaz @marcoscaceres