Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dfn from CSS-2023 #882

Closed
tabatkins opened this issue Feb 17, 2023 · 2 comments · Fixed by w3c/reffy#1212
Closed

Missing dfn from CSS-2023 #882

tabatkins opened this issue Feb 17, 2023 · 2 comments · Fixed by w3c/reffy#1212

Comments

@tabatkins
Copy link
Member

The dfn at https://drafts.csswg.org/css-2023/#vendor-prefix defines the terms "vendor-prefix"/"unprefixed"/etc, but this doesn't show up in https://github.com/w3c/webref/blob/main/ed/dfns/css-2023.json. (It looks like every other dfn shows up in the data, just this one is conspicuously missing.)

@tidoust
Copy link
Member

tidoust commented Feb 18, 2023

The definition gets filtered out because it links to an external spec (CSS2). The code responsible for that in the crawler is at:
https://github.com/w3c/reffy/blob/main/src/browserlib/extract-dfns.mjs#L265-L271

That rule was added to cope with specs that import definitions from other specifications using a form like This specification uses the term <dfn><a href="URL of bar">foo</a></dfn> defined in bar. If the crawler does not filter this out, there will be duplicate definitions of foo in the resulting cross-referencing database, one defined in "bar", and one defined in the spec that imports the definition.

In this particular case, the reference is not really to a dfn in CSS2. I'll try to find a way to relax the rule while still avoiding the creation of duplicate definitions.

@tabatkins
Copy link
Member Author

Ah yes, that's a very good heuristic for the general case. Thanks in advance for fixing it for this specific misfire. ^_^

tidoust added a commit to w3c/reffy that referenced this issue Feb 21, 2023
Fixes w3c/webref#882 pending a more proper dfns
curation process as envisioned in w3c/webref#789
tidoust added a commit to w3c/reffy that referenced this issue Feb 21, 2023
Fixes w3c/webref#882 pending a more proper dfns
curation process as envisioned in w3c/webref#789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants