Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CSP check to RTCPeerConnection.addIceCandidate(). #81

Merged
merged 14 commits into from
Jun 15, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 39 additions & 15 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,30 @@ <h3>RTP header control</h3>
</p>
</section>
</section>
<section id="rtcpeerconnection-interface">
<h3>
{{RTCPeerConnection}} extensions
</h3>
<p>
The {{RTCPeerConnection}} interface is defined in [[WEBRTC]]. This document
extends that interface by using Content-Security-Policy for ICE candidate
filtering.
</p>
<section>
<h2>Modifications to existing procedures</h2>

<p>Append the following paragraph to the
<a data-cite="WEBRTC#dfn-administratively-prohibited">administratively prohibited</a>
algorithm:</p>

<p>If <a data-cite="CSP#should-block-rtc-connection">
should RTC connections be blocked for global?</a> with the
[=relevant global object=] of the {{RTCPeerConnection}} object in question
returns `"Blocked"`, then all candidates MUST be <a
data-cite="WEBRTC#dfn-administratively-prohibited">
administratively prohibited</a>.</p>
</section>
</section>
<section id="rtcrtptransceiver-interface">
<h3>
{{RTCRtpTransceiver}} extensions
Expand All @@ -109,7 +133,7 @@ <h3>
partial dictionary RTCRtpHeaderExtensionCapability {
RTCRtpTransceiverDirection direction = "sendrecv";
};

partial interface RTCRtpTransceiver {
undefined setOfferedRtpHeaderExtensions(
sequence&lt;RTCRtpHeaderExtensionCapability&gt; headerExtensionsToOffer);
Expand Down Expand Up @@ -422,7 +446,7 @@ <h2>Dictionary {{RTCRtpEncodingParameters}} Members</h2>
<div class="issue atrisk">
<p>
{{RTCRtpEncodingParameters/ptime}} was moved from [[WEBRTC]] to
this specification due to lack of support from implementers. It is
this specification due to lack of support from implementers. It is
therefore marked as a feature at risk.
</p>
</div>
Expand Down Expand Up @@ -677,7 +701,7 @@ <h3>Removed features</h3>
This section documents features that were moved from [[WEBRTC]] to this extension
specification due to lack of support from implementers.
</p>
<section id="rtcpeerconnection-interface">
<section id="removed-rtcpeerconnection-features">
<h3>
{{RTCPeerConnection}} extensions
</h3>
Expand Down Expand Up @@ -824,7 +848,7 @@ <h3>
<div class="issue atrisk">
<p>
The {{RTCOAuthCredential}} dictionary was moved from [[WEBRTC]] to
this specification due to lack of support from implementers. It is
this specification due to lack of support from implementers. It is
therefore marked as a feature at risk.
</p>
</div>
Expand Down Expand Up @@ -957,12 +981,12 @@ <h2>Dictionary {{RTCIceServer}} Members</h2>
<p>An example array of {{RTCIceServer}} objects is:</p>
<pre class="example highlight">
<code>{
urls: 'turns:turn2.example.net',
username: '22BIjxU93h/IgwEb',
credential: {
macKey: 'WmtzanB3ZW9peFhtdm42NzUzNG0=',
accessToken: 'AAwg3kPHWPfvk9bDFL936wYvkoctMADzQ5VhNDgeMR3+ZlZ35byg972fW8QjpEl7bx91YLBPFsIhsxloWcXPhA=='
},
urls: 'turns:turn2.example.net',
username: '22BIjxU93h/IgwEb',
credential: {
macKey: 'WmtzanB3ZW9peFhtdm42NzUzNG0=',
accessToken: 'AAwg3kPHWPfvk9bDFL936wYvkoctMADzQ5VhNDgeMR3+ZlZ35byg972fW8QjpEl7bx91YLBPFsIhsxloWcXPhA=='
},
credentialType: 'oauth'
}</code></pre>
</section>
Expand Down Expand Up @@ -994,7 +1018,7 @@ <h3>
<div class="issue atrisk">
<p>
{{RTCRtpSynchronizationSource/voiceActivityFlag}} was moved from [[WEBRTC]] to
this specification due to lack of support from implementers. It is therefore
this specification due to lack of support from implementers. It is therefore
marked as a feature at risk.
</p>
</div>
Expand All @@ -1005,7 +1029,7 @@ <h3>
<section class="informative">
<h2>
Security Considerations
</h2>
</h2>
<p>
This section is non-normative; it specifies no new behaviour.
The overall security considerations of the general set
Expand All @@ -1029,14 +1053,14 @@ <h2>
<p>
This document defines extensions for encryption of RTP Header Extensions which
improve the confidentiality of communications by encrypting header extension
IDs, as well as CSRCs.
IDs, as well as CSRCs.
</p>
</section>
</section>
<section class="informative">
<h2>
Privacy Considerations
</h2>
</h2>
<p>
This section is non-normative; it specifies no new behaviour.
</p>
Expand All @@ -1047,7 +1071,7 @@ <h2>
<p>
The extensions defined in this document do not reveal additional
information on IP addresses beyond that already described in
[[WEBRTC]] Section 13.2.
[[WEBRTC]] Section 13.2.
</p>
</section>
<section>
Expand Down