Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fully active" section should mention which error to throw if non-fully active docs are not supported #395

Open
johannhof opened this issue Sep 2, 2022 · 2 comments

Comments

@johannhof
Copy link
Contributor

...or maybe this should be specified in https://html.spec.whatwg.org/multipage/browsers.html#fully-active.

There are a bunch of APIs that simply err out when run in/with a non-fully active document, but they're not all consistent in which error they reject with or throw. The most common and logical one seems to be "InvalidStateError", so maybe that should be the guidance?

@domenic
Copy link
Member

domenic commented Sep 27, 2022

/cc @rakina

@rakina
Copy link
Contributor

rakina commented Sep 29, 2022

Seems reasonable but I'd like to note that the current non-fully-active handling guide is specifically for documents that are not fully active due to BFCache, while those errors seems more suited for documents that are not fully active because they're detached from the frame, and it's also mostly being moved out to a separate doc just for bfcache (see PR), so not sure where to fit the guidance there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants