-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review request on Render Blocking Status in Resource Timing #753
Comments
@ylafon & I reviewed the proposal during our London F2F today. The developer use cases and proposed addition to fetch and Resource Timing all make sense. One question that came up was about the attribute type. Why did you define it as string and not boolean? |
The main reasoning was to keep it open to being extended later on, if we wanted to provide more supporting information regarding render blocking. Say we have a scenario where a plain script element is present in the The final value that is exposed was defined as string to keep it open to such extensions or others if they were to be deemed useful later on. |
How about using an enum in that case? That would avoid using strings to be used to carry extra information using micro-syntax, where another value would be better |
Thanks for the suggestion. An |
Hi @abinpaul1 thanks for that! On that basis, we're happy to close. Thank you for flying TAG. |
The type of the field is changed to an enum as suggested as part of TAG review (see w3ctag/design-reviews#753 (comment)) Bug: 1337256 Change-Id: I5916c236e26475aa45bd3a5faa5baf3839d7909d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812241 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/main@{#1032721} NOKEYCHECK=True GitOrigin-RevId: b0da995377b830ba6ded0e30a27a10d1d068136a
Wotcher TAG!
I'm requesting a TAG review of Render Blocking Status in Resource Timing.
Adds a field to PerfomanceResourceTiming to indicate the render blocking status of a resource. Currently from a developer perspective, the only way to determine which resources were actually render blocking is to rely on complex heurestics. The new field would instead provide a direct signal regarding the same.
Further details:
You should also know that...
Reception towards a similar feature introduced in Chromium was very positive. The article and tweet linked below is a good indicator.
We'd prefer the TAG provide feedback as :
💬 leave review feedback as a comment in this issue and @-notify @abinpaul1 @yoavweiss
The text was updated successfully, but these errors were encountered: