Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review request on Render Blocking Status in Resource Timing #753

Closed
1 task done
abinpaul1 opened this issue Jul 2, 2022 · 5 comments
Closed
1 task done

Review request on Render Blocking Status in Resource Timing #753

abinpaul1 opened this issue Jul 2, 2022 · 5 comments
Assignees
Labels
chromium-high-priority Something that the Chromium team would like the TAG to prioritise Progress: review complete Resolution: satisfied The TAG is satisfied with this design Topic: performance Venue: Web Performance WG

Comments

@abinpaul1
Copy link

abinpaul1 commented Jul 2, 2022

Wotcher TAG!

I'm requesting a TAG review of Render Blocking Status in Resource Timing.

Adds a field to PerfomanceResourceTiming to indicate the render blocking status of a resource. Currently from a developer perspective, the only way to determine which resources were actually render blocking is to rely on complex heurestics. The new field would instead provide a direct signal regarding the same.

Further details:

  • I have reviewed the TAG's Web Platform Design Principles
  • Relevant time constraints or deadlines: September 1, 2022
  • The group where the work on this specification is currently being done: W3C Web Performance WG
  • Major unresolved issues with or opposition to this specification: None
  • This work is being funded by: Google

You should also know that...

Reception towards a similar feature introduced in Chromium was very positive. The article and tweet linked below is a good indicator.

We'd prefer the TAG provide feedback as :

💬 leave review feedback as a comment in this issue and @-notify @abinpaul1 @yoavweiss

@torgo torgo added this to the 2022-07-25-F2F-London milestone Jul 20, 2022
@chrishtr chrishtr added the chromium-high-priority Something that the Chromium team would like the TAG to prioritise label Jul 20, 2022
@atanassov
Copy link

@ylafon & I reviewed the proposal during our London F2F today. The developer use cases and proposed addition to fetch and Resource Timing all make sense. One question that came up was about the attribute type. Why did you define it as string and not boolean?

@atanassov atanassov added the Progress: propose closing we think it should be closed but are waiting on some feedback or consensus label Jul 27, 2022
@abinpaul1
Copy link
Author

abinpaul1 commented Jul 27, 2022

The main reasoning was to keep it open to being extended later on, if we wanted to provide more supporting information regarding render blocking.

Say we have a scenario where a plain script element is present in the head and another plain script element is dynamically added to head. The former is blocking and the latter is non-blocking, so say we had a string value saying dynamically-injected-non-blocking, we could maybe convey more information regarding why it was non-blocking as well. The proposal started out with a couple more such values before deciding to rely on the boolean.

The final value that is exposed was defined as string to keep it open to such extensions or others if they were to be deemed useful later on.

@ylafon
Copy link
Member

ylafon commented Jul 28, 2022

How about using an enum in that case? That would avoid using strings to be used to carry extra information using micro-syntax, where another value would be better

@abinpaul1
Copy link
Author

Thanks for the suggestion. An enum does seem to be better suited. The explainer and spec have been updated to use an enum field instead of the string type.

@torgo
Copy link
Member

torgo commented Aug 25, 2022

Hi @abinpaul1 thanks for that! On that basis, we're happy to close. Thank you for flying TAG.

@torgo torgo closed this as completed Aug 25, 2022
@torgo torgo added Resolution: satisfied The TAG is satisfied with this design and removed Progress: propose closing we think it should be closed but are waiting on some feedback or consensus labels Aug 25, 2022
@torgo torgo removed this from the 2022-08-22-week milestone Aug 25, 2022
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
The type of the field is changed to an enum as suggested as part of TAG review (see w3ctag/design-reviews#753 (comment))

Bug: 1337256
Change-Id: I5916c236e26475aa45bd3a5faa5baf3839d7909d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812241
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032721}
NOKEYCHECK=True
GitOrigin-RevId: b0da995377b830ba6ded0e30a27a10d1d068136a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromium-high-priority Something that the Chromium team would like the TAG to prioritise Progress: review complete Resolution: satisfied The TAG is satisfied with this design Topic: performance Venue: Web Performance WG
Projects
None yet
Development

No branches or pull requests

6 participants