Dockerfile rework #2939
Merged
Dockerfile rework #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mutantcornholio
commented
May 21, 2024
•
mutantcornholio
commented
- Negative approach to .dockerignore
- Reintruduction of turbo
- Removed unnecessary apt-get calls
- Moved docs compilation into a separate layer, which gets cached
- Changed turbo paths to actual output directories
Closed
mutantcornholio
force-pushed
the
yuri/dockerfile-rework
branch
2 times, most recently
from
3aaba7e to
d9cacf2
Compare
ironoa
reviewed
May 21, 2024
mutantcornholio
force-pushed
the
yuri/dockerfile-rework
branch
9 times, most recently
from
71ac3c9 to
814edff
Compare
* Negative approach to .dockerignore * Reintruduction of turbo * Removed unnecessary apt-get calls * Moved docs compilation into a separate layer, which gets cached * Changed turbo paths to actual output directories
mutantcornholio
force-pushed
the
yuri/dockerfile-rework
branch
from
814edff to
780b077
Compare
ironoa
reviewed
May 22, 2024
|
can we remove the building of the not used images (worker, ...) from the pipeline ? |
mutantcornholio
force-pushed
the
yuri/dockerfile-rework
branch
from
8d97cab to
e573cdc
Compare
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.