Making docker image thinner #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By splitting build into two stages, we'll take only docs/build into the layers. `yarn workspaces focus --production` removes all devDependencies, which also aren't needed after build. `date-fns` wasn't specified in deps at all, but needed at runtime. Fixed. The result: image went from 1.26GB to 472MB
ironoa
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By splitting build into two stages, we'll take only docs/build into the layers.
yarn workspaces focus --productionremoves all devDependencies, which also aren't needed after build.date-fnswasn't specified in deps at all, but needed at runtime. Fixed.The result: image went from 1.26GB to 472MB