Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ink! analyzer (phase 2) - milestone 5 #1041

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Conversation

davidsemakula
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1904 < please fill this in with the PR number of your application.

@keeganquigley
Copy link
Contributor

Thanks for the delivery @davidsemakula someone will look at it within the next few days, as we currently have a backlog.

@takahser takahser self-requested a review November 2, 2023 08:57
@takahser takahser self-assigned this Nov 2, 2023
@davidsemakula
Copy link
Contributor Author

@takahser Added more notes and updated the recommended tag for testing to a newer release.

Copy link
Contributor

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidsemakula thanks for your patience, it looks mostly good already. I had troubles with spinning up the docker infrastructure though. Feel free to have a look at my evaluation for more details.

@davidsemakula
Copy link
Contributor Author

@takahser thanks for the thorough review and feedback.

I've pushed a fix for the docker issue to the master branch.
You'll need to pull the latest changes from master, and also rebuild the docker image before running it again.

@takahser takahser self-requested a review November 8, 2023 09:30
@davidsemakula
Copy link
Contributor Author

@takahser LMK if I need to clarify anything for the docker fix.

Copy link
Contributor

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidsemakula it's all fine, I've retested it, and it worked well! You can find the final evaluation here.

@takahser takahser merged commit c92d49f into w3f:master Nov 14, 2023
3 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@davidsemakula
Copy link
Contributor Author

Thanks for the review @takahser 🎉
I've sent the invoice via the form.

@davidsemakula
Copy link
Contributor Author

@RouvenP just checking in since it's about 2 weeks now since the approval 🙂

@RouvenP
Copy link

RouvenP commented Nov 28, 2023

hi @davidsemakula the payment will be settled today - I will let you know as soon as done!

@RouvenP
Copy link

RouvenP commented Nov 28, 2023

hi @davidsemakula the transfer is done

@davidsemakula
Copy link
Contributor Author

Hi @RouvenP received, thanks!

@davidsemakula davidsemakula deleted the ink-analyzer branch December 4, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants