Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infimum: milestone 2 #1231

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Infimum: milestone 2 #1231

merged 1 commit into from
Dec 19, 2024

Conversation

rhysbalevicius
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1948

@rhysbalevicius rhysbalevicius changed the title Infimum: mileston 2 Infimum: milestone 2 Dec 9, 2024
@keeganquigley
Copy link
Contributor

Hi @rhysbalevicius thanks for the delivery.

curl --output e2e.tar.gz https://cdn.rhys.tech/infimum/e2e.tar.gz works, but when I run the command tar xf e2e.tar.gz -C cli/__tests__ I get the following:

tar: cli/__tests__: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now

It's probably something simple, can you check to ensure that the file and path are correct? Thanks.

@rhysbalevicius
Copy link
Contributor Author

tar: cli/tests: Cannot open: No such file or directory

Hey @keeganquigley! Thanks for your time.

It looks like the issue is the current working directory you're executing the command from (i.e. should download the test data and extract to the cli/__tests__ directory all from the root of the infimum repo). I can reproduce this error message if I try to extract the archive to a non-existent directory.

That is, prior to these steps you should change your working directory via cd /path/to/infimum (where /path/to here is replaced relative to where the repo is cloned). So for example:

git clone https://github.com/rhysbalevicius/infimum.git
cd infimum
curl --output e2e.tar.gz https://cdn.rhys.tech/infimum/e2e.tar.gz
tar xf e2e.tar.gz -C cli/__tests__

Alternatively, you could drop the -C cli/__tests__ option and manually move the extracted data directory into the tests directory, e.g.

git clone https://github.com/rhysbalevicius/infimum.git
cd infimum
curl --output e2e.tar.gz https://cdn.rhys.tech/infimum/e2e.tar.gz
tar xf e2e.tar.gz
mv data cli/__tests__

Let me know if you run into any other issues. Thanks again!

@keeganquigley
Copy link
Contributor

Thanks @rhysbalevicius much appreciated, that helped and I was able to get everything running. I'm happy to accept the milestone, and here is my final evaluation. For the next milestone, consider adding more unit tests to test more than just happy paths.

Thanks and have a happy holidays!

@keeganquigley keeganquigley merged commit 71d37a0 into w3f:master Dec 19, 2024
3 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@rhysbalevicius
Copy link
Contributor Author

Amazing. Thank you @keeganquigley!

For the next milestone, consider adding more unit tests to test more than just happy paths.

Very good point, I will definitely do that.

Happy holidays :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants