Spartan PoC Consensus: Milestone 2

[rg3l3dr]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application PR: w3f/Grants-Program#357

[Noc2]

Thanks for the delivery. We will look into it as soon as possible.

[semuelle]

Hey @rg3l3dr, I'm running into an error running cargo test. Any idea what might be missing here?

error[E0308]: mismatched types
   --> client/consensus/poc/src/tests.rs:481:50
    |
481 |                       let _ = solution_sender.send(Some(Solution {
    |  __________________________________________________^
482 | |                         public_key: FarmerId::from_slice(&keypair.public.to_bytes()),
483 | |                         nonce,
484 | |                         encoding: encoding.to_vec(),
485 | |                         signature: keypair.sign(ctx.bytes(&tag)).to_bytes().to_vec(),
486 | |                         tag,
487 | |                     }));
    | |______________________^ expected struct `sp_consensus_poc::digests::Solution`, found enum `std::option::Option`
    |
    = note: expected struct `sp_consensus_poc::digests::Solution`
                 found enum `std::option::Option<sp_consensus_poc::digests::Solution>`

[rg3l3dr]

Hi @semuelle -- that was a typo from refactoring, we've fixed with this commit. Test will compile and run now.

[semuelle]

Thanks for following up on the compilation issue, @rg3l3dr. I just pushed my evaluation notes and your milestone is hereby accepted. 🎉

I wasn't able to build the Docker image manually, maybe you could look into that. There is a bunch of uncommented and undocumented code (including tests marked as Milestone 2!), but I can see that there are a lot of changes still happening and this is only milestone 2, so I'll postpone judgement on that until the next one. :)

I will forward your invoice for processing.

[RouvenP]

hi @rg3l3dr we transferred the payment for milestone 2.