Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadratic Funding M2 Delivery from OAK Network #284

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Conversation

chrisli30
Copy link
Contributor

@chrisli30 chrisli30 commented Oct 6, 2021

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#268

@Noc2 Noc2 self-assigned this Oct 7, 2021
@Noc2
Copy link
Collaborator

Noc2 commented Oct 7, 2021

Thanks for the delivery. I started look into it, but I have a few questions/comments:

  • First of all, it seems you simply submitted the project that participated already in the hackathon. This is against our guidelines. We only support additional/new development via grants.
  • Second it seems the design was never shared with us, regarding "We will create UI sketches to demonstrate the user flow of the web application, and post here for advice"
  • Also, since you didn't use any APIs to Polkadot js, we would need to amend the original contract.

Given that you participated in the hackathon with the same project and it doesn’t look like you put any additional work into the project (according to the contract and let me know in case I'm missing something), my recommendation would actually be to cancel the current contract. That said we would still be interested to support additional projects/improvements via our grant program.

@chrisli30
Copy link
Contributor Author

chrisli30 commented Oct 7, 2021

Hey @Noc2 , thanks for taking a look. To your questions,

  • First of all, it seems you simply submitted the project that participated already in the hackathon. This is against our guidelines. We only support additional/new development via grants.
    Yes, I'm well aware of the rules.

The goal of this submission is to share our code as open-source to Polkadot community but not to claim the reward. I accept your verdict.

  • Second it seems the design was never shared with us, regarding "We will create UI sketches to demonstrate the user flow of the web application, and post here for advice"

My mistake. Skipped a couple of steps in the communication process.

  • Also, since you didn't use any APIs to Polkadot js, we would need to amend the original contract.

No, we heavily leveraged polkadot.js. In my delivery report, I meant that we didn't need to modify the existing code of polkadot.js as we thought.

Given that you participated in the hackathon with the same project and it doesn’t look like you put any additional work into the project.

Many improvements were actually added to make the project more mature.

  • Added responsive mobile layout.
  • Fixed bugs in historical contribution chart
  • Added transaction query via modified Polkascan data service (this actually took us quite some time due to lack of documentation and out-of-sync code with Substrate blockchain). Now you can click on the "View the transaction" to check out the creation transaction of quadratic funding projects, or any transaction on OAK Testnet.

Overall, we did put in a good amount of effort into the product and will leverage it for the grant programs of OAK canary network. Your verdict is reasonable, and I have no problem with that. We're well funded with OAK's Seed for now.

Since we have been awarded by the hackathon. Could we complete the M2 delivery and submit the code with an adjusted award of $0?

@Noc2
Copy link
Collaborator

Noc2 commented Oct 8, 2021

Thanks for the quick reply and explanation. This sounds good to me. Could you create a PR to update the contract accordingly: https://github.com/w3f/Grants-Program/blob/master/applications/quadratic-funding.md (0 DAI for milestone 2, total costs 20k, remove javascript library and UI design)? Once this is merged, I will accept the milestone delivery and the grant is officially done.

@chrisli30
Copy link
Contributor Author

Sounds good, thanks David @Noc2.

I've created a PR for it. w3f/Grants-Program#635

@Noc2
Copy link
Collaborator

Noc2 commented Oct 11, 2021

Just to confirm it here. Milestone is hereby accepted. I will update the grants accepted list.

@Noc2 Noc2 merged commit d9e4334 into w3f:master Oct 11, 2021
@chrisli30
Copy link
Contributor Author

Just to confirm it here. Milestone is hereby accepted. I will update the grants accepted list.

Thank you, David!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants