Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typechain Polkadot Milestone 1 #747

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

coreggon11
Copy link
Contributor

Milestone Delivery Checklist

Link to the application pull request: https://github.com/w3f/Grants-Program/blob/master/applications/typechain-polkadot-follow-up-2.md

@coreggon11 coreggon11 changed the title Create typechain-polkadot-follow-up-2.md Typechain Polkadot Milestone 3 Feb 13, 2023
Copy link
Contributor

@0xCaso 0xCaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coreggon11, thanks for the new delivery! We'll get back to you as soon as possible.

In the meantime, could you do this little edit to the delivery document?

deliveries/typechain-polkadot-follow-up-2.md Outdated Show resolved Hide resolved
Co-authored-by: Matteo Casonato <matteocasonato@protonmail.com>
@varex83
Copy link
Contributor

varex83 commented Feb 16, 2023

Hello, @0xCaso do you have any updates regarding our delivery?

@0xCaso
Copy link
Contributor

0xCaso commented Feb 17, 2023

Apologies for the delay, currently we have some backlog. If no one will start the evaluation today, for sure it will be done during the start of the next week.

@0xCaso 0xCaso self-assigned this Feb 20, 2023
@0xCaso
Copy link
Contributor

0xCaso commented Feb 20, 2023

Hi guys, sorry again. I started the evaluation, and I'll ask you here if I need your help!
By the way, you were meaning "Milestone 1" in the PR name, right? Just to double check

@0xCaso 0xCaso changed the title Typechain Polkadot Milestone 3 Typechain Polkadot Milestone 1 Feb 20, 2023
@varex83
Copy link
Contributor

varex83 commented Feb 20, 2023

Hello @0xCaso , yes

Copy link
Contributor

@0xCaso 0xCaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying the guide for the typechain-compiler (this one) and when I try to use the compiler, I get the following error:

======== Found contracts ========
	flipper,
	my_psp22
======== Compiling flipper ========
ERROR: Mismatching versions of `parity-scale-codec` were found!
Please ensure that your contract and your ink! dependencies use a compatible version of this package.
Error: Command failed: cargo +nightly contract build --manifest-path ./contracts/flipper/Cargo.toml
ERROR: Mismatching versions of `parity-scale-codec` were found!
Please ensure that your contract and your ink! dependencies use a compatible version of this package.

Maybe there is something wrong in the Cargo.toml files?

Also, I had to edit the package.json file, updating "@polkadot/keyring": "^9.13.4" to "@polkadot/keyring": "^10.4.2"

@0xCaso
Copy link
Contributor

0xCaso commented Feb 21, 2023

Ok, I updated cargo-contract and now I get a different error:

Compiling flipper v0.1.0 (/private/var/folders/9_/h5h1hjb11qzddpjd7kr1sn380000gn/T/cargo-contract_2sbo1C)
   Compiling metadata-gen v0.1.0 (/private/var/folders/9_/h5h1hjb11qzddpjd7kr1sn380000gn/T/cargo-contract_2sbo1C/.ink/metadata_gen)
    Finished release [optimized] target(s) in 22.97s
     Running `target/ink/release/metadata-gen ''`
Error: ENOENT: no such file or directory, open '/GitHub/typechain-compiler-example/contracts/flipper/target/ink/metadata.json'
    at Object.openSync (node:fs:600:3)
    at Object.readFileSync (node:fs:468:35)
    at main (/GitHub/typechain-compiler-example/node_modules/@727-ventures/typechain-compiler/index.ts:114:11)
    at Object.<anonymous> (/GitHub/typechain-compiler-example/node_modules/@727-ventures/typechain-compiler/index.ts:143:1)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module.m._compile (/GitHub/typechain-compiler-example/node_modules/ts-node/src/index.ts:1618:23)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Object.require.extensions.<computed> [as .ts] (/GitHub/typechain-compiler-example/node_modules/ts-node/src/index.ts:1621:12)
    at Module.load (node:internal/modules/cjs/loader:1037:32)
    at Function.Module._load (node:internal/modules/cjs/loader:878:12) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: '/GitHub/typechain-compiler-example/contracts/flipper/target/ink/metadata.json'
}

@varex83
Copy link
Contributor

varex83 commented Feb 21, 2023

Hello @0xCaso, thanks for the quick response, do you use CARGO_TARGET_DIR? Also can you check if target directory located in the ./contracts/flipper

@0xCaso
Copy link
Contributor

0xCaso commented Feb 21, 2023

This is what's inside /contract/flipper/target/ink:

Screenshot 2023-02-21 at 17 11 30

For CARGO_TARGET_DIR, how can I see this?

@varex83
Copy link
Contributor

varex83 commented Feb 21, 2023

Okay, nevermind about CARGO_TARGET DIR :D, so your problem is that you are using the newer version of cargo-contract (now it saves as .json, use-ink/cargo-contract#952), try to use cargo-contract-contract 2.0.0-beta.1, and by the way I will update TC :D

@varex83
Copy link
Contributor

varex83 commented Feb 21, 2023

@0xCaso try to use @727-ventures/typechain-compiler@0.5.16

@0xCaso
Copy link
Contributor

0xCaso commented Feb 21, 2023

Thanks a lot for the super fast replies and update, now it works perfectly!
I'll update you tomorrow :)

Copy link
Contributor

@0xCaso 0xCaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you fix in the guide and in the article the following things:

  • The keyring correct version that I mentioned

    Also, I had to edit the package.json file, updating "@polkadot/keyring": "^9.13.4" to "@polkadot/keyring": "^10.4.2"

  • npx @727-Ventures/typechain-compiler --config typechain.config.json has @727-Ventures instead of @727-ventures, which makes the command fail

  • Specify if it's needed to use @727-ventures/typechain-compiler@0.5.16, or @727-ventures/typechain-compiler is sufficient

@varex83
Copy link
Contributor

varex83 commented Feb 22, 2023

Hello, @0xCaso okay, will be done in a few minutes

@varex83
Copy link
Contributor

varex83 commented Feb 22, 2023

@0xCaso done ✅

Copy link
Contributor

@0xCaso 0xCaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot again for the quick fix! I'm approving the milestone :)

@varex83
Copy link
Contributor

varex83 commented Feb 22, 2023

Thank you too @0xCaso for the quick review and replies! Appreciate that!

@semuelle semuelle reopened this Feb 22, 2023
@semuelle semuelle merged commit 6cd3f30 into w3f:master Feb 22, 2023
@github-actions
Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. If you haven't already, reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

@github-actions
Copy link

We noticed that this is the last milestone of your project. Congratulations on completing your grant!

So, where to from here? The main goal of the W3F grants program is to support research as well as early-stage technical projects. So, if your project still falls under one of those categories, you might want to apply for a follow-up grant. Depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step, for example:

Project with a Business Case/Token: Substrate Builders Program or VC Funding

Common Good Projects: Treasury Funding

For a more comprehensive list, see our Alternative Funding page.
Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.

@0xCaso
Copy link
Contributor

0xCaso commented Feb 22, 2023

Thank you too @0xCaso for the quick review and replies! Appreciate that!

Thanks!

Did you send the invoice for this milestone?

@varex83
Copy link
Contributor

varex83 commented Feb 22, 2023

Thank you too @0xCaso for the quick review and replies! Appreciate that!

Thanks!

Did you send the invoice for this milestone?

Yes

@0xCaso
Copy link
Contributor

0xCaso commented Feb 22, 2023

I found it, but seems like you've sent an old one (Sol2Ink milestone 2 grant) on Feb 13

@coreggon11
Copy link
Contributor Author

Hi @0xCaso that is my fault, I probably mixed it up. I will fix it ASAP.

@coreggon11
Copy link
Contributor Author

Fixed. Sorry for incovenience

@0xCaso
Copy link
Contributor

0xCaso commented Feb 22, 2023

Thanks, and no worries.

Sorry for this, but could you resend the invoice with:

  • "Typechain follow-up 2 Milestone 1 grant" instead of "Typechain Milestone 3 grant"
  • the VAT Amount (also if it's 0)

@coreggon11
Copy link
Contributor Author

Hi @0xCaso the new invoice was submitted.

@0xCaso
Copy link
Contributor

0xCaso commented Feb 23, 2023

Thanks a lot, I forwarded it internally. The payment should happen within 14 days!

@coreggon11
Copy link
Contributor Author

Hi @0xCaso, do you have any updates regarding the payment? 😄

@0xCaso
Copy link
Contributor

0xCaso commented Mar 9, 2023

Hi @coreggon11, apologies for the delay. The payment should happen tomorrow.

@RouvenP
Copy link

RouvenP commented Mar 10, 2023

hi @coreggon11 we just transferred the payment. Apologies for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants