External evaluation of ink_analyzer milestone 3

[dastansam]

In general, well documented and well-written code. There are some non-critical clippy warnings that can be addressed easily.

Looking forward to VSCode integration in the next milestone!

Link to the application pull request: w3f/Grants-Program#1615
Link to the milestone delivery: #900

[davidsemakula]

@dastansam Thanks for the review and feedback! 🙂

There are some non-critical clippy warnings that can be addressed easily.

I've pushed style updates for inlining all format! arguments (among other things) so the non-critical clippy warnings should be resolved.

Looking forward to VSCode integration in the next milestone!

The VS Code extension should be ready by the end of this month (July), I'll make sure to ping you 🙂 .

[keeganquigley]

Thanks a bunch @dastansam great job as per usual. I'm happy to go ahead and accept it. I did have trouble running two tests, did you have any problems initially? See my comment here.

[RouvenP]

hi @dastansam we transferred the payment yesterday

[davidsemakula]

@dastansam Just FYI 🙂
The VS Code extension is available at https://marketplace.visualstudio.com/items?itemName=ink-analyzer.ink-analyzer
Or you can get the VSIX directly from https://github.com/ink-analyzer/ink-vscode/releases