Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ink Playground IDE Improvements #1731

Merged
merged 10 commits into from
May 19, 2023
Merged

Ink Playground IDE Improvements #1731

merged 10 commits into from
May 19, 2023

Conversation

radhe-zeeve
Copy link
Contributor

Project Abstract

Zeeve will improve Ink! Playground capabilities to keep the Playground environment to be up to date with the Ink advancements and also improve the Ink Crate docs.

We understand the on-paper maximum for a Level 2 grant is for $25,000, but the scope of this project requires 3 FTE-months and we were told earlier in the process that we can make a case to go beyond that limit.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (ink-playground-ide-improvements.md).
  • I have read the application guidelines.
  • A BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (aUSD/USDT) address for the payment of the milestones is provided in the application.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. Our team username's are: @ghanzeeve:matrix.org & @radhezeeve::matrix.org

@CLAassistant
Copy link

CLAassistant commented May 10, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ gnv-zeeve
✅ radhe-zeeve
❌ arjunzeeve
You have signed the CLA already but the status is still pending? Let us recheck it.

@radhe-zeeve radhe-zeeve force-pushed the master branch 2 times, most recently from beaecba to 4dc9bf5 Compare May 11, 2023 19:01
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the application. In general, it looks good to me and I'm happy to already approve it, but let me also share it with the ink! team.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing: Could @arjunzeeve still sign the terms and conditions?

@Noc2 Noc2 added discussion private Discussion of application happens in private. changes requested The team needs to clarify a few things first. labels May 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2023

The applicant has requested the discussion of the application to happen in a private chat room.

@gnv-zeeve
Copy link
Contributor

One minor thing: Could @arjunzeeve still sign the terms and conditions?

Seems like this isn't working, details shared on private chat.

@gnv-zeeve
Copy link
Contributor

One minor thing: Could @arjunzeeve still sign the terms and conditions?

It seems to have stuck, we did try it multiple times as well as using different browsers. Shared screenshots on private chat. Please suggest a way out.

@Noc2
Copy link
Collaborator

Noc2 commented May 17, 2023

I looked into it, and I believe it's okay. We had this issue before, and it happened because of a spelling issue that does seem to cause problems with the bot.arjun-zeeve has successfully signed the terms. See below:

Screenshot 2023-05-17 at 07 58 30

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(one additional minor comment in the private chat, but I'm generally happy to go ahead with it)

@Noc2 Noc2 mentioned this pull request May 17, 2023
10 tasks
Signed-off-by: Jasti Sri Radhe Shyam <radheshyam.jasti@zeeve.io>
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I'm happy to go ahead with it.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels May 17, 2023
@Noc2 Noc2 merged commit 3264089 into w3f:master May 19, 2023
@github-actions
Copy link
Contributor

Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions.

Before you start, take a moment to read through our announcement guidelines for all communications related to the grant or make them known to the right person in your organisation. In particular, please don't announce the grant publicly before at least the first milestone of your project has been approved. At that point or shortly before, you can get in touch with us at grantsPR@web3.foundation and we'll be happy to collaborate on an announcement about the work you’re doing.

Lastly, please remember to let us know in case you run into any delays or deviate from the deliverables in your application. You can either leave a comment here or directly request to amend your application via PR. We wish you luck with your project! 🚀

@JoshOrndorff
Copy link
Contributor

@radhe-zeeve It seems the current ink-playgroud.substrate.io is down. Some details in:

Do you use kubernetes when working on the playground?

@radhe-zeeve
Copy link
Contributor Author

@JoshOrndorff we are aware ink-playgroud.substrate.io is down. As mentioned in the issue Polkadot team is trying to migrate to pure k8 based deployment, as for the current development we are using docker, if anything changes in deployment process we would pivot and make adjustments to our development to accommodate the new deployment process.

@keeganquigley
Copy link
Contributor

Hi @radhe-zeeve just left a comment in the private channel, FYI.

@keeganquigley
Copy link
Contributor

Hi @radhe-zeeve how is the milestone coming along?

@radhe-zeeve
Copy link
Contributor Author

radhe-zeeve commented Oct 20, 2023

@keeganquigley We have already created PR for one of the issue and marked it ready for review recently Add new Ink Version update support by radhe-zeeve · Pull Request #815 · paritytech/ink-playground, resolution for other two issues required for the first milestone is being worked on and will be presented in few days.

@keeganquigley
Copy link
Contributor

Thanks @radhe-zeeve feel free to provide an update in the private Element chat.

@radhe-zeeve
Copy link
Contributor Author

I will be delivering an final updated code within the next couple of days.

@keeganquigley
Copy link
Contributor

Hi @radhe-zeeve still planning on delivering this?

@radhe-zeeve
Copy link
Contributor Author

@keeganquigley already opened the PR last week and pinged cmichi on the PR, no response yet

PR's: use-ink/ink-playground#817, use-ink/ink-playground#815

@keeganquigley
Copy link
Contributor

Thanks for the update @radhe-zeeve yes unfortunately it will probably be a while since they are swamped. In the meantime, in order to get paid for this milestone we would need you to submit a delivery PR in the repo: https://github.com/w3f/Grant-Milestone-Delivery

Its okay if the PRs are still open, but that way you can document what work was done. Are you able to complete this? Thanks!

@radhe-zeeve
Copy link
Contributor Author

@keeganquigley Sure, will open a PR with documentation on https://github.com/w3f/Grant-Milestone-Delivery.

@semuelle
Copy link
Member

pinging @radhe-zeeve

@gnv-zeeve
Copy link
Contributor

Hey @semuelle let us know in case you still have some open items on this and we can quickly close them.

cc: @radhe-zeeve

@semuelle
Copy link
Member

Thanks, @gnv-zeeve. We have a bit of a backlog at the moment, so it will probably take a few more days. I'll share feedback on the pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion private Discussion of application happens in private. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants