Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async backing parameters and fix image references #5524

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

mrcnski
Copy link
Contributor

@mrcnski mrcnski commented Jan 21, 2024

Follow-up to #5506 with fixes.
Addition of final step is based on paritytech/polkadot-sdk#2236

cc @evilrobot-01 @darkfriend77

@mrcnski
Copy link
Contributor Author

mrcnski commented Jan 21, 2024

cc @seadanda if you want to have a look also.

Copy link
Contributor

@filippoweb3 filippoweb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to merge.

Copy link
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/maintain/maintain-guides-async-backing.md Outdated Show resolved Hide resolved
@@ -214,6 +214,22 @@ This phase consists of changes to your parachain’s runtime that activate async

![minimum-period](../assets/async/async-backing-minimum-period.png)

6. **Update parameters:** Once the runtime is deployed the final step is to update three parameters!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case these had to be set on local relay to then propagate to parachain, so might be useful to explicitly mention that these are on the relay and only required for local testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, let me know if that's clear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nicely done!

@DrW3RK DrW3RK merged commit 7d9db7e into w3f:master Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants