Issue #10: add some examples and doc-tests for the derive.rs module #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks! Appears my CI sucks right now. I've mostly fixed it in #110 but not exported or backported yet. I'll merge this once I figure out what to do there. |
Makes rand_chacha a feature to avoid build warnings
|
Thanks. I have added a new commit that hopefully should remove the build warning that was making the tests fail. |
Fixes clippy error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution to schnorrkel, so I may have missed lots of things.
Please take it in good spirit. It addresses this issue which mentions
derive.rsandmulti.rs. I only worked inderive.rs, becausemulti.rsdoes not seem to exist.