Implemented secret handling #12
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| access_token = load_env('ACCESS_TOKEN') | ||
| SCRAPE_INTERVAL = load_env('SCRAPE_INTERVAL', 30) | ||
| except KeyError as error: | ||
| print(str(error)[1:-1]) |
There was a problem hiding this comment.
This is a bit obtuse, but Python will put quotes around the message of KeyError - so we strip the first and last character to have a proper error message printed to the console (foo instead of 'foo')
|
Thank you for your valuable contribution. We truly appreciate your efforts, and we will make sure to merge your PR as soon as possible. |
|
@wacken89 nice! Could you also do a new released soon? That would be great. Thank you for merging! |
|
Sure, I'm going to do it. I just need to update the readme on how to use files |
|
@wacken89 Just added a new PR with the Readme update :) |
As promised in #11, this PR adds support for secret files.
Many container orchestrators provide a way to inject secret configuration values into application securely by mounting read-only files into their file system; the application is expected to read those files upon starting up.
These changes modify configuration loading to:
FOO, if definedFOO_PATH, if definedIf all three variants fail, and no default value is passed, a KeyError is raised. This should provide solid configuration handling and allow to specify all values as environment variables or secret files, with the environment always taking precedence - so existing installations are not affected.