Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: 공지 태그 FOREIGN -> INTERNATIONAL #286

Merged
merged 3 commits into from
Jun 8, 2024

Conversation

huGgW
Copy link
Collaborator

@huGgW huGgW commented Jun 6, 2024

제목

Refactor: 공지 태그 FOREIGN -> INTERNATIONAL

f97609d Feat: Add validation for notice search pagesize, pagenum.
ff9eb34 Refactor: Refactor Enum.values() to Enum.entries
147e744 Refactor: Change FOREIGN -> INTERNATIONAL

TODO

  • 추후 krName도 database에 저장하도록 수정.

@huGgW huGgW added the Refactor label Jun 6, 2024
@huGgW huGgW requested a review from leeeryboy June 6, 2024 08:18
@huGgW huGgW self-assigned this Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

Test Results

11 files  ±0  11 suites  ±0   1s ⏱️ ±0s
50 tests ±0  50 ✔️ ±0  0 💤 ±0  0 ±0 
56 runs  ±0  56 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 147e744. ± Comparison against base commit 9715c40.

Copy link
Contributor

@leeeryboy leeeryboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huGgW huGgW merged commit 5c0454e into develop Jun 8, 2024
3 checks passed
@huGgW huGgW deleted the refactor/foreign_to_international branch June 8, 2024 08:04
@huGgW huGgW mentioned this pull request Jun 8, 2024
huGgW added a commit that referenced this pull request Jun 8, 2024
- Refactor: 공지 태그 FOREIGN -> INTERNATIONAL (Refactor: 공지 태그 FOREIGN -> INTERNATIONAL #286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants