Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 공지사항 수정, 삭제, 태그 기능 추가 #3
feat: 공지사항 수정, 삭제, 태그 기능 추가 #3
Changes from 7 commits
068225a
8d8d5cd
0382376
3f2e94d
be6d433
c349869
b9d9756
750877c
a8d5ec6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
request.tag 가 null 인 경우는 어떤 경우인가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
프론트에서 수정사항을 보낼때 tag에서 변화가 없는 상황이면 null을 보내는 상황을 생각했습니다. 일반적으로 tag 변화 없어도 수정때 null로 보내는 게 아니라면 말해주면 수정하겠습니다. 케바케면 프론트랑 논의하고 거기에 맞출게요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 이 부분은 프론트랑 소통이 필요해보이네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@transactional 이 필요해보이는데, 어제 회의에서 태그는 그냥 고정으로 가져가자 하면 enrollTag 기능 자체가 딱히 필요없을것 같기도 합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아.. 이거는 가끔 db 갈아엎고 태그 만들 때 쓰고 있는 애라서 나중에 없애도록 할게요.