Feat: Staff 두 언어 묶어서 동작하는 V2 API 정의 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeryboy
approved these changes
Jul 29, 2024
Comment on lines
+64
to
+65
| val koreanStaffDto = createStaff(LanguageType.KO, createStaffLanguagesReqBody.ko, mainImage) | ||
| val englishStaffDto = createStaff(LanguageType.EN, createStaffLanguagesReqBody.en, mainImage) |
There was a problem hiding this comment.
createStaff에서 이미지 업로드 두번 될것 같은데 괜찮을까?
Comment on lines
+172
to
+173
| val koStaffDto = updateStaff(koStaffId, updateStaffLanguagesReqBody.ko, newImage) | ||
| val enStaffDto = updateStaff(enStaffId, updateStaffLanguagesReqBody.en, newImage) |
|
수정할까 했는데 생각보다 뜯어고쳐야 될게 많네 이미지 하나만 업로드되고 제거되게 하려면... |
huGgW
force-pushed
the
feat/combine_language/staff
branch
from
2df86fb to
5f13cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: Staff 두 언어 묶어서 동작하는 V2 API 정의
상세 설명
TODO