학사 및 교과 연도별 api에 첨부파일 추가 #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huGgW
approved these changes
Nov 27, 2024
| @@ -1,5 +1,6 @@ | |||
| package com.wafflestudio.csereal.core.academics.api.req | |||
|
|
|||
| data class UpdateYearReq( | |||
| val description: String | |||
| val description: String, | |||
| val deleteIds: List<Long>? = null | |||
There was a problem hiding this comment.
deleteAttachmentIds 같이 네이밍만 명확하게 바꾸면 좋을듯!
There was a problem hiding this comment.
이거 다른데서 이렇게 쓰고 있는데 찬솔이가 통일하는게 편하다했어서 일단 그대로 가야할듯..
There was a problem hiding this comment.
이거 전체 v2로 옮기는거 나중에 한번 하면 좋을듯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.