design: QA

wafflestudio · Mar 27, 2024 · afbeba0 · afbeba0
1 parent daf03f8
commit afbeba0
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 12 deletions.
diff --git a/app/[locale]/search/MemberSection.tsx b/app/[locale]/search/MemberSection.tsx
@@ -49,7 +49,7 @@ const MemberCell = ({ name, academicRankOrRole, imageURL, memberType, id }: Memb
   const href = `${memberType === 'PROFESSOR' ? facultyPath : staffPath}/${id}`;
 
   return (
-    <Link className="flex flex-col gap-3" href={href}>
+    <Link className="group flex flex-col gap-3" href={href}>
       <ImageWithFallback
         src={imageURL}
         alt={`${name} 프로필`}
@@ -64,7 +64,9 @@ const MemberCell = ({ name, academicRankOrRole, imageURL, memberType, id }: Memb
         }}
       />
       <div className="flex items-end gap-1">
-        <h3 className="text-[1.04169rem] font-bold text-neutral-950">{name}</h3>
+        <h3 className="text-[1.04169rem] font-bold text-neutral-950 group-hover:underline">
+          {name}
+        </h3>
         <p className="text-md font-normal text-neutral-500">{academicRankOrRole}</p>
       </div>
     </Link>

diff --git a/app/[locale]/search/helper/BasicRow.tsx b/app/[locale]/search/helper/BasicRow.tsx
@@ -16,7 +16,7 @@ type BasicRowProps = {
 export default function BasicRow({ href, title, node, ...description }: BasicRowProps) {
   return (
     <Link className="ml-5 flex flex-col gap-[0.63rem]" href={href}>
-      <h3 className="text-base font-bold">{title}</h3>
+      <h3 className="text-base font-bold hover:underline">{title}</h3>
       <RangeBolded {...description} />
       <p className="text-md font-medium text-main-orange hover:underline">{`${node.parent?.name} > ${node?.name}`}</p>
     </Link>

diff --git a/app/[locale]/search/helper/CircleTitle.tsx b/app/[locale]/search/helper/CircleTitle.tsx
@@ -2,7 +2,7 @@ export default function CircleTitle({ title, size }: { title: string; size?: num
   // TODO: 번역 적용
   // const t = useTranslations();
   return (
-    <div className="flex items-center gap-2">
+    <div className="ml-[0.8rem] flex items-center gap-2">
       <OrangeCircle />
       <h3 className=" text-[1.0625rem] font-semibold leading-loose text-neutral-950">
         {title}

diff --git a/app/[locale]/search/helper/NavbarButton.tsx b/app/[locale]/search/helper/NavbarButton.tsx
@@ -6,16 +6,16 @@ import { TreeNode } from './SearchSubNavbar';
 
 export default function NavbarButton({ node, style }: { node: TreeNode; style: CSSProperties }) {
   return (
-    <p
+    <button
       onClick={() => scrollToSection(`nav_${node.name}`)}
-      className={`block text-sm ${node.bold ? 'font-bold text-main-orange' : 'text-neutral-700'} ${
-        node.size === undefined || node.size === 0 ? 'pointer-events-none' : ''
-      }`}
+      className={`block text-left text-sm ${
+        node.bold ? 'font-bold text-main-orange' : 'text-neutral-700'
+      } ${node.size === undefined || node.size === 0 ? 'pointer-events-none' : ''}`}
       style={style}
     >
       {node.name}
       {node.size !== undefined && `(${node.size})`}
-    </p>
+    </button>
   );
 }
 
@@ -24,5 +24,5 @@ const scrollToSection = (id: string) => {
   if (target === null) return;
 
   const pos = target.getBoundingClientRect();
-  window.scrollTo({ left: pos.left, top: pos.top + window.scrollY - 100, behavior: 'smooth' });
+  window.scrollTo({ top: pos.top + window.scrollY - 100, behavior: 'smooth' });
 };
diff --git a/app/[locale]/search/helper/NoticeRow.tsx b/app/[locale]/search/helper/NoticeRow.tsx
@@ -23,7 +23,7 @@ export default function NoticeRow({ id, title, dateStr, ...description }: Notice
     <Link className="flex flex-col gap-[.62rem]" href={`${noticePath}/${id}`}>
       <h3 className="text-base font-bold leading-none text-neutral-950">{title}</h3>
       <RangeBolded {...description} />
-      <time className="text-md font-medium leading-none text-main-orange">
+      <time className="text-md font-medium leading-none text-main-orange hover:cursor-text">
         {date.getFullYear()}/{date.getMonth() + 1}/{date.getDate()}
       </time>
     </Link>

diff --git a/app/[locale]/search/helper/Section.tsx b/app/[locale]/search/helper/Section.tsx
@@ -15,7 +15,7 @@ export default function Section({
 
   return (
     <div className="flex flex-col" id={`nav_${title.replace(' ', '_')}`}>
-      <div className="mb-[2.88rem] flex">
+      <div className="mb-8 flex">
         <h3 className="inline border-b-2 border-neutral-200 pb-[.59rem] pl-[.63rem] pr-[.63rem] text-[1.25rem] font-semibold leading-loose text-neutral-950">
           {t(title)}({size})
         </h3>