feat: tweaked error inheritence for UserRejectedRequestError & SwitchChainError
#328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b0d8ab8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TldrTweaked error inheritance for Detailed summary
|
|
Size Change: +43 B (0%) Total Size: 57 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
========================================
Coverage 99.86% 99.86%
========================================
Files 263 263
Lines 16899 17016 +117
Branches 1805 1817 +12
========================================
+ Hits 16876 16993 +117
Misses 21 21
Partials 2 2
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
jxom
added a commit
that referenced
this pull request
Apr 7, 2023
* fix: make `GetValue` return `{ value?: never }` for contract functions that are not payable (#310)
fix: GetValue type
* Version Packages (#311)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* refactor: use `@adraffy/ens-normalize` for ENS normalization (#313)
* refactor: use @adraffy/ens-normalize for ENS normalization
* docs: update
* Version Packages (#315)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: `transports` property type on `FallbackTransport` (#317)
* Version Packages (#318)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: migrate to nodenext module resolution
* chore: fix type imports
* chore: use `bundler` module resolution for playgrounds so that path aliases are simpler
* fix: ethers adapter signTransaction properties (#322)
* fix: ethers adapter
* test: boost coverage
* Version Packages (#324)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: skip invalid logs (#326)
* fix: skip invalid logs
* chore: format
* chore: changeset
* Version Packages (#327)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` (#328)
* feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError`
* chore: format
* chore: switch to tsc
* chore: apply rome formatting & linting changes
* chore: bump to typescript v5
* chore: remove tsup config
* chore: improve build step
* chore: add comment to version.ts
* chore: fix imports
* chore: add changeset
* chore: fix type imports
* chore: ignore tsbuildinfo
* fix: type issues
* chore: Contains -> Or
* chore: format
* chore: format
---------
Co-authored-by: jxom <jakemoxey@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: awkweb <tom@meagher.co>
jxom
added a commit
that referenced
this pull request
Apr 7, 2023
* fix: make `GetValue` return `{ value?: never }` for contract functions that are not payable (#310)
fix: GetValue type
* Version Packages (#311)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* refactor: use `@adraffy/ens-normalize` for ENS normalization (#313)
* refactor: use @adraffy/ens-normalize for ENS normalization
* docs: update
* Version Packages (#315)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: `transports` property type on `FallbackTransport` (#317)
* Version Packages (#318)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: migrate to nodenext module resolution
* chore: fix type imports
* chore: use `bundler` module resolution for playgrounds so that path aliases are simpler
* fix: ethers adapter signTransaction properties (#322)
* fix: ethers adapter
* test: boost coverage
* Version Packages (#324)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: skip invalid logs (#326)
* fix: skip invalid logs
* chore: format
* chore: changeset
* Version Packages (#327)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` (#328)
* feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError`
* chore: format
* chore: switch to tsc
* chore: apply rome formatting & linting changes
* chore: bump to typescript v5
* chore: remove tsup config
* chore: improve build step
* chore: add comment to version.ts
* chore: fix imports
* chore: add changeset
* chore: fix type imports
* chore: ignore tsbuildinfo
* fix: type issues
* chore: Contains -> Or
* chore: format
* chore: format
---------
Co-authored-by: jxom <jakemoxey@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: awkweb <tom@meagher.co>
jxom
added a commit
that referenced
this pull request
Apr 7, 2023
* chore: switch to tsc * chore: apply rome formatting & linting changes * chore: bump to typescript v5 * chore: remove tsup config * chore: improve build step * chore: add comment to version.ts * chore: fix imports * chore: add changeset * chore: revert uts46 import changes * chore: fix type imports * chore: ignore tsbuildinfo * fix: type issues * chore: Contains -> Or * chore: format * chore: switch to nodenext module resolution (#309) * fix: make `GetValue` return `{ value?: never }` for contract functions that are not payable (#310) fix: GetValue type * Version Packages (#311) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * refactor: use `@adraffy/ens-normalize` for ENS normalization (#313) * refactor: use @adraffy/ens-normalize for ENS normalization * docs: update * Version Packages (#315) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: `transports` property type on `FallbackTransport` (#317) * Version Packages (#318) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: migrate to nodenext module resolution * chore: fix type imports * chore: use `bundler` module resolution for playgrounds so that path aliases are simpler * fix: ethers adapter signTransaction properties (#322) * fix: ethers adapter * test: boost coverage * Version Packages (#324) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: skip invalid logs (#326) * fix: skip invalid logs * chore: format * chore: changeset * Version Packages (#327) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` (#328) * feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` * chore: format * chore: switch to tsc * chore: apply rome formatting & linting changes * chore: bump to typescript v5 * chore: remove tsup config * chore: improve build step * chore: add comment to version.ts * chore: fix imports * chore: add changeset * chore: fix type imports * chore: ignore tsbuildinfo * fix: type issues * chore: Contains -> Or * chore: format * chore: format --------- Co-authored-by: jxom <jakemoxey@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: awkweb <tom@meagher.co> * Delete eleven-donkeys-lay.md * Delete jsconfig.json * Update cuddly-candles-begin.md --------- Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: awkweb <tom@meagher.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
UserRejectedRequestErrorandSwitchChainErrorcould come from another source (not just RPC – could be WalletConnect, Coinbase SDK, etc), making it so you can pass an arbitrary cause to these errors.