Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ethers adapter signTransaction properties #322

Merged
merged 2 commits into from
Apr 6, 2023
Merged

fix: ethers adapter signTransaction properties #322

merged 2 commits into from
Apr 6, 2023

Conversation

tmm
Copy link
Member

@tmm tmm commented Apr 6, 2023

Fixes #319

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2023

🦋 Changeset detected

Latest commit: dc5f0cf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 8:46pm
viem-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 8:46pm

@pr-codex
Copy link

pr-codex bot commented Apr 6, 2023

Tldr

This PR fixes properties passed to ethers adapter signTransaction.

Detailed summary

  • A new test file ethers.test.ts has been added.
  • A new method ethersWalletToAccount has been added to ethers.ts file.
  • The ethersWalletToAccount method has been modified to include type mappings.
  • The signTransaction method has been modified to include allowed fields, eip1559 properties, and untyped transactions support for accessList.
  • ethersWalletToAccount method has been tested.
  • signMessage, signTransaction, and signTypedData methods have been tested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Size Change: +229 B (0%)

Total Size: 56.7 kB

Filename Size Change
dist/ethers.js 752 B +229 B (+44%) 🚨
ℹ️ View Unchanged
Filename Size
dist/abi.js 258 B
dist/accounts/index.js 1.37 kB
dist/chains.js 2.03 kB
dist/chunk-3IHFW55B.js 43 kB
dist/chunk-EW5GG2YC.js 417 B
dist/contract.js 439 B
dist/ens.js 340 B
dist/index.js 5.54 kB
dist/public.js 458 B
dist/test.js 507 B
dist/utils/index.js 1.2 kB
dist/wallet.js 297 B
dist/window.js 67 B

compressed-size-action

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #322 (dc5f0cf) into main (4b3c233) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   99.88%   99.86%   -0.02%     
==========================================
  Files         262      263       +1     
  Lines       16807    16899      +92     
  Branches     1795     1805      +10     
==========================================
+ Hits        16787    16876      +89     
- Misses         18       21       +3     
  Partials        2        2              
Impacted Files Coverage Δ
src/adapters/ethers.ts 96.73% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jxom jxom merged commit ea019d7 into main Apr 6, 2023
@jxom jxom deleted the tmm/fix-319 branch April 6, 2023 21:33
@github-actions github-actions bot mentioned this pull request Apr 6, 2023
jxom added a commit that referenced this pull request Apr 7, 2023
* fix: make `GetValue` return `{ value?: never }` for contract functions that are not payable (#310)

fix: GetValue type

* Version Packages (#311)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* refactor: use `@adraffy/ens-normalize` for ENS normalization (#313)

* refactor: use @adraffy/ens-normalize for ENS normalization

* docs: update

* Version Packages (#315)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: `transports` property type on `FallbackTransport` (#317)

* Version Packages (#318)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: migrate to nodenext module resolution

* chore: fix type imports

* chore: use `bundler` module resolution for playgrounds so that path aliases are simpler

* fix: ethers adapter signTransaction properties (#322)

* fix: ethers adapter

* test: boost coverage

* Version Packages (#324)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: skip invalid logs (#326)

* fix: skip invalid logs

* chore: format

* chore: changeset

* Version Packages (#327)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` (#328)

* feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError`

* chore: format

* chore: switch to tsc

* chore: apply rome formatting & linting changes

* chore: bump to typescript v5

* chore: remove tsup config

* chore: improve build step

* chore: add comment to version.ts

* chore: fix imports

* chore: add changeset

* chore: fix type imports

* chore: ignore tsbuildinfo

* fix: type issues

* chore: Contains -> Or

* chore: format

* chore: format

---------

Co-authored-by: jxom <jakemoxey@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: awkweb <tom@meagher.co>
jxom added a commit that referenced this pull request Apr 7, 2023
* fix: make `GetValue` return `{ value?: never }` for contract functions that are not payable (#310)

fix: GetValue type

* Version Packages (#311)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* refactor: use `@adraffy/ens-normalize` for ENS normalization (#313)

* refactor: use @adraffy/ens-normalize for ENS normalization

* docs: update

* Version Packages (#315)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: `transports` property type on `FallbackTransport` (#317)

* Version Packages (#318)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: migrate to nodenext module resolution

* chore: fix type imports

* chore: use `bundler` module resolution for playgrounds so that path aliases are simpler

* fix: ethers adapter signTransaction properties (#322)

* fix: ethers adapter

* test: boost coverage

* Version Packages (#324)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: skip invalid logs (#326)

* fix: skip invalid logs

* chore: format

* chore: changeset

* Version Packages (#327)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` (#328)

* feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError`

* chore: format

* chore: switch to tsc

* chore: apply rome formatting & linting changes

* chore: bump to typescript v5

* chore: remove tsup config

* chore: improve build step

* chore: add comment to version.ts

* chore: fix imports

* chore: add changeset

* chore: fix type imports

* chore: ignore tsbuildinfo

* fix: type issues

* chore: Contains -> Or

* chore: format

* chore: format

---------

Co-authored-by: jxom <jakemoxey@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: awkweb <tom@meagher.co>
jxom added a commit that referenced this pull request Apr 7, 2023
* chore: switch to tsc

* chore: apply rome formatting & linting changes

* chore: bump to typescript v5

* chore: remove tsup config

* chore: improve build step

* chore: add comment to version.ts

* chore: fix imports

* chore: add changeset

* chore: revert uts46 import changes

* chore: fix type imports

* chore: ignore tsbuildinfo

* fix: type issues

* chore: Contains -> Or

* chore: format

* chore: switch to nodenext module resolution (#309)

* fix: make `GetValue` return `{ value?: never }` for contract functions that are not payable (#310)

fix: GetValue type

* Version Packages (#311)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* refactor: use `@adraffy/ens-normalize` for ENS normalization (#313)

* refactor: use @adraffy/ens-normalize for ENS normalization

* docs: update

* Version Packages (#315)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: `transports` property type on `FallbackTransport` (#317)

* Version Packages (#318)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: migrate to nodenext module resolution

* chore: fix type imports

* chore: use `bundler` module resolution for playgrounds so that path aliases are simpler

* fix: ethers adapter signTransaction properties (#322)

* fix: ethers adapter

* test: boost coverage

* Version Packages (#324)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: skip invalid logs (#326)

* fix: skip invalid logs

* chore: format

* chore: changeset

* Version Packages (#327)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` (#328)

* feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError`

* chore: format

* chore: switch to tsc

* chore: apply rome formatting & linting changes

* chore: bump to typescript v5

* chore: remove tsup config

* chore: improve build step

* chore: add comment to version.ts

* chore: fix imports

* chore: add changeset

* chore: fix type imports

* chore: ignore tsbuildinfo

* fix: type issues

* chore: Contains -> Or

* chore: format

* chore: format

---------

Co-authored-by: jxom <jakemoxey@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: awkweb <tom@meagher.co>

* Delete eleven-donkeys-lay.md

* Delete jsconfig.json

* Update cuddly-candles-begin.md

---------

Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: awkweb <tom@meagher.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ethers wallet send transactions not working
2 participants