-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ethers adapter signTransaction properties #322
Conversation
🦋 Changeset detectedLatest commit: dc5f0cf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TldrThis PR fixes properties passed to Detailed summary
|
Size Change: +229 B (0%) Total Size: 56.7 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 99.88% 99.86% -0.02%
==========================================
Files 262 263 +1
Lines 16807 16899 +92
Branches 1795 1805 +10
==========================================
+ Hits 16787 16876 +89
- Misses 18 21 +3
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* fix: make `GetValue` return `{ value?: never }` for contract functions that are not payable (#310) fix: GetValue type * Version Packages (#311) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * refactor: use `@adraffy/ens-normalize` for ENS normalization (#313) * refactor: use @adraffy/ens-normalize for ENS normalization * docs: update * Version Packages (#315) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: `transports` property type on `FallbackTransport` (#317) * Version Packages (#318) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: migrate to nodenext module resolution * chore: fix type imports * chore: use `bundler` module resolution for playgrounds so that path aliases are simpler * fix: ethers adapter signTransaction properties (#322) * fix: ethers adapter * test: boost coverage * Version Packages (#324) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: skip invalid logs (#326) * fix: skip invalid logs * chore: format * chore: changeset * Version Packages (#327) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` (#328) * feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` * chore: format * chore: switch to tsc * chore: apply rome formatting & linting changes * chore: bump to typescript v5 * chore: remove tsup config * chore: improve build step * chore: add comment to version.ts * chore: fix imports * chore: add changeset * chore: fix type imports * chore: ignore tsbuildinfo * fix: type issues * chore: Contains -> Or * chore: format * chore: format --------- Co-authored-by: jxom <jakemoxey@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: awkweb <tom@meagher.co>
* fix: make `GetValue` return `{ value?: never }` for contract functions that are not payable (#310) fix: GetValue type * Version Packages (#311) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * refactor: use `@adraffy/ens-normalize` for ENS normalization (#313) * refactor: use @adraffy/ens-normalize for ENS normalization * docs: update * Version Packages (#315) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: `transports` property type on `FallbackTransport` (#317) * Version Packages (#318) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: migrate to nodenext module resolution * chore: fix type imports * chore: use `bundler` module resolution for playgrounds so that path aliases are simpler * fix: ethers adapter signTransaction properties (#322) * fix: ethers adapter * test: boost coverage * Version Packages (#324) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: skip invalid logs (#326) * fix: skip invalid logs * chore: format * chore: changeset * Version Packages (#327) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` (#328) * feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` * chore: format * chore: switch to tsc * chore: apply rome formatting & linting changes * chore: bump to typescript v5 * chore: remove tsup config * chore: improve build step * chore: add comment to version.ts * chore: fix imports * chore: add changeset * chore: fix type imports * chore: ignore tsbuildinfo * fix: type issues * chore: Contains -> Or * chore: format * chore: format --------- Co-authored-by: jxom <jakemoxey@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: awkweb <tom@meagher.co>
* chore: switch to tsc * chore: apply rome formatting & linting changes * chore: bump to typescript v5 * chore: remove tsup config * chore: improve build step * chore: add comment to version.ts * chore: fix imports * chore: add changeset * chore: revert uts46 import changes * chore: fix type imports * chore: ignore tsbuildinfo * fix: type issues * chore: Contains -> Or * chore: format * chore: switch to nodenext module resolution (#309) * fix: make `GetValue` return `{ value?: never }` for contract functions that are not payable (#310) fix: GetValue type * Version Packages (#311) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * refactor: use `@adraffy/ens-normalize` for ENS normalization (#313) * refactor: use @adraffy/ens-normalize for ENS normalization * docs: update * Version Packages (#315) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: `transports` property type on `FallbackTransport` (#317) * Version Packages (#318) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: migrate to nodenext module resolution * chore: fix type imports * chore: use `bundler` module resolution for playgrounds so that path aliases are simpler * fix: ethers adapter signTransaction properties (#322) * fix: ethers adapter * test: boost coverage * Version Packages (#324) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: skip invalid logs (#326) * fix: skip invalid logs * chore: format * chore: changeset * Version Packages (#327) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` (#328) * feat: tweaked error inheritence for `UserRejectedRequestError` & `SwitchChainError` * chore: format * chore: switch to tsc * chore: apply rome formatting & linting changes * chore: bump to typescript v5 * chore: remove tsup config * chore: improve build step * chore: add comment to version.ts * chore: fix imports * chore: add changeset * chore: fix type imports * chore: ignore tsbuildinfo * fix: type issues * chore: Contains -> Or * chore: format * chore: format --------- Co-authored-by: jxom <jakemoxey@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: awkweb <tom@meagher.co> * Delete eleven-donkeys-lay.md * Delete jsconfig.json * Update cuddly-candles-begin.md --------- Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: awkweb <tom@meagher.co>
Fixes #319