Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbars appearance in Darkmode #204

Closed
PaarthAgarwal opened this issue Aug 24, 2022 · 5 comments
Closed

Scrollbars appearance in Darkmode #204

PaarthAgarwal opened this issue Aug 24, 2022 · 5 comments
Labels
good first issue Good for newcomers

Comments

@PaarthAgarwal
Copy link
Member

PaarthAgarwal commented Aug 24, 2022

There comes a point when there are 3 vertical scrollbars and 1 horizontal scrollbar on one page, which looks a bit odd, particularly in dark mode.

In dark mode:
image

In light mode:
image

Quick fixes I have in mind:

  1. Change the colour of scrollbars for dark mode.
  2. Make it slimmer, more transparent and may even make the slider a bit curved.

Actions

  1. Work out why the scrollbar on the TOC is showing a horizontal scroll and ensure that it no longer does that, content should wrap in this container.
  2. Potential - add scrollbar-width: thin; to the inner and main TOC containers with a note about progressive adoption
@tbrlpld
Copy link
Collaborator

tbrlpld commented Aug 25, 2022

Can you override the system scroll bar styles with CSS alone?

Why is there even scroll bars around the page TOC? I feel having the page TOC static would be ok and not as annoying as the previously static main TOC. And the horizontal scrolling should definitely be avoided.

@PaarthAgarwal
Copy link
Member Author

Can you override the system scroll bar styles with CSS alone?

Yes, I think we can.
https://css-tricks.com/almanac/properties/s/scrollbar-color/

Why is there even scroll bars around the page TOC?

I added it because there was an issue for it
#9

@tbrlpld
Copy link
Collaborator

tbrlpld commented Aug 25, 2022

Ah, fair enough. I forget which page was the use case.

But i guess preventing horizontal would still be good

@lb-
Copy link
Member

lb- commented Aug 31, 2022

I agree preventing horizontal scrolling would be good and an action from this issue.

I am not convinced styling the scrollbar is a good option, I think that it can come across as tacky and it works against the OS's decision on styling here.

However, we could look at just using the slimmer scrollbar-width option.

But it might be a while before browsers support it, however, it could be added with a comment that it will work as browsers adopt it.

@lb- lb- added the good first issue Good for newcomers label Aug 31, 2022
lb- pushed a commit to kkartik07/sphinx_wagtail_theme that referenced this issue Oct 11, 2022
lb- pushed a commit to kkartik07/sphinx_wagtail_theme that referenced this issue Oct 11, 2022
@lb- lb- closed this as completed in 1583711 Oct 11, 2022
@lb-
Copy link
Member

lb- commented Oct 11, 2022

Note - the PR #215 only fixed the horizontal scroll but I think that is sufficient for now.

If we feel that we must do some other styling hacks to change the look of the scroll bars we can raise a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants