Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved / #297 #298

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Resolved / #297 #298

merged 1 commit into from
Oct 31, 2024

Conversation

ayaan-qadri
Copy link
Contributor

@ayaan-qadri ayaan-qadri commented Oct 30, 2024 •
edited
Loading

Resolves: #297

The issue was caused by interpreting the element with the .toctree-expand class as a direct child of the <a> tag, when both are actually direct child of the element with the .current class in our use case.

resolve-297.mp4

thibaudcolas
thibaudcolas approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! :)

@thibaudcolas thibaudcolas merged commit 7a6d673 into wagtail:main Oct 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaudcolas thibaudcolas thibaudcolas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon should be changed to minus(-) when the topic is expanded
2 participants
@ayaan-qadri @thibaudcolas