Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter network change #1270

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: filter network change #1270

wants to merge 2 commits into from
+97 −27

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Dec 23, 2024 •
edited
Loading

Description

If there is a network type change i.e from wifi to 4G even if it involves an intermediary transition to offline, then unsubscribe and resubscribe all filters.

This is to avoid filter-push issue noticed as per https://discord.com/channels/1110799176264056863/1111541184490393691/1318842541436829717.

@status-im-auto
Copy link

status-im-auto commented Dec 23, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8cf3a00 #1 2024-12-23 09:55:11 ~2 min unknown 📄log
✔️ 43b58a4 #2 2024-12-24 05:19:30 ~2 min unknown 📄log
✔️ a366a27 #3 2024-12-24 05:31:21 ~2 min unknown 📄log
✔️ 8ee28da #4 2024-12-24 06:08:30 ~2 min unknown 📄log
✔️ 016405b #5 2024-12-24 09:06:40 ~2 min unknown 📄log
✔️ c976ba0 #6 2024-12-24 09:40:11 ~2 min unknown 📄log
✔️ 2dd4165 #7 2024-12-25 05:32:47 ~2 min unknown 📄log
✔️ a49ea9c #8 2024-12-25 07:49:22 ~2 min unknown 📄log
✔️ 95c6217 #9 2025-01-02 06:15:28 ~2 min unknown 📄log
✔️ 49615a9 #10 2025-01-02 07:25:03 ~2 min unknown 📄log
✔️ decbc60 #11 2025-01-02 08:12:12 ~2 min unknown 📄log
✔️ 1b44a2a #12 2025-01-02 09:59:47 ~2 min unknown 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9c3a460 #13 2025-01-02 11:01:55 ~3 min unknown 📄log
✔️ ce98bbc #14 2025-01-02 11:46:15 ~2 min unknown 📄log

@chaitanyaprem chaitanyaprem changed the title fix : filter network change fix: filter network change Dec 23, 2024
@chaitanyaprem chaitanyaprem mentioned this pull request Dec 23, 2024
Open
1 task
@chaitanyaprem chaitanyaprem force-pushed the fix/filter-network-change branch 3 times, most recently from a366a27 to 8ee28da Compare December 24, 2024 06:06
@chaitanyaprem chaitanyaprem force-pushed the fix/filter-network-change branch 4 times, most recently from 2dd4165 to a49ea9c Compare December 25, 2024 07:46
@chaitanyaprem chaitanyaprem force-pushed the fix/filter-network-change branch 5 times, most recently from 1b44a2a to 9c3a460 Compare January 2, 2025 10:57
@chaitanyaprem chaitanyaprem force-pushed the fix/filter-network-change branch from 9c3a460 to ce98bbc Compare January 2, 2025 11:43
@chaitanyaprem chaitanyaprem marked this pull request as ready for review January 2, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plopezlpz plopezlpz Awaiting requested review from plopezlpz

@richard-ramos richard-ramos Awaiting requested review from richard-ramos richard-ramos is a code owner

@kaichaosun kaichaosun Awaiting requested review from kaichaosun

At least 1 approving review is required to merge this pull request.

Assignees

@chaitanyaprem chaitanyaprem

Labels
None yet
Projects
Waku
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaitanyaprem @status-im-auto @kaichaosun