Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: topic refactors for filter client #750

Merged
merged 1 commit into from
Sep 19, 2023
Merged

feat: topic refactors for filter client #750

merged 1 commit into from
Sep 19, 2023

Conversation

vitvly
Copy link
Contributor

@vitvly vitvly commented Sep 18, 2023 •
edited
Loading

Changes included:

  • Rename Topic to PubsubTopic to match spec
  • Use set for ContentFilter.ContentTopics
  • client.Subscribe() will return an already existing subscription if we happen to run into the same [peer,contentFilter] pair

@status-im-auto
Copy link

status-im-auto commented Sep 18, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (42)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 6ae26c0 #1 2023-09-18 10:22:05 ~15 sec nix-flake 📄log
❌ 6ae26c0 #1 2023-09-18 10:23:02 ~1 min linux 📄log
✖️ 6ae26c0 #1 2023-09-18 10:23:15 ~1 min tests 📄log
✖️ 6ae26c0 #1 2023-09-18 10:23:21 ~1 min tests 📄log
❌ 6ae26c0 #1 2023-09-18 10:24:26 ~2 min android 📄log
❌ 6ae26c0 #1 2023-09-18 10:24:36 ~2 min ios 📄log
✖️ e1846eb #2 2023-09-18 10:58:28 ~16 sec nix-flake 📄log
❌ e1846eb #2 2023-09-18 10:58:52 ~42 sec linux 📄log
✔️ e1846eb #2 2023-09-18 11:01:10 ~2 min tests 📄log
✔️ e1846eb #2 2023-09-18 11:01:24 ~3 min tests 📄log
✔️ e1846eb #2 2023-09-18 11:02:01 ~3 min android 📦tgz
✔️ e1846eb #2 2023-09-18 11:02:01 ~3 min ios 📦tgz
✖️ 5b678c4 #3 2023-09-18 11:08:05 ~12 sec nix-flake 📄log
❌ 5b678c4 #3 2023-09-18 11:08:22 ~30 sec linux 📄log
✔️ 5b678c4 #3 2023-09-18 11:08:49 ~55 sec tests 📄log
✔️ 5b678c4 #3 2023-09-18 11:09:43 ~1 min tests 📄log
✔️ 5b678c4 #3 2023-09-18 11:11:10 ~3 min android 📦tgz
✔️ 5b678c4 #3 2023-09-18 11:11:36 ~3 min ios 📦tgz
✖️ 9a04cb9 #4 2023-09-18 11:13:27 ~13 sec nix-flake 📄log
✔️ 9a04cb9 #4 2023-09-18 11:14:11 ~58 sec tests 📄log
✔️ 9a04cb9 #4 2023-09-18 11:15:02 ~1 min tests 📄log
✔️ 9a04cb9 #4 2023-09-18 11:15:30 ~2 min linux 📦deb
✔️ 9a04cb9 #4 2023-09-18 11:16:15 ~3 min android 📦tgz
✔️ 9a04cb9 #4 2023-09-18 11:16:47 ~3 min ios 📦tgz
✖️ 4e89483 #5 2023-09-18 11:17:37 ~23 sec nix-flake 📄log
✔️ 4e89483 #5 2023-09-18 11:19:09 ~1 min tests 📄log
✔️ 4e89483 #5 2023-09-18 11:19:23 ~2 min tests 📄log
✔️ 4e89483 #5 2023-09-18 11:19:51 ~2 min linux 📦deb
✔️ 4e89483 #5 2023-09-18 11:20:26 ~3 min android 📦tgz
✔️ 4e89483 #5 2023-09-18 11:20:49 ~3 min ios 📦tgz
✖️ 6359995 #6 2023-09-19 11:32:42 ~25 sec nix-flake 📄log
✔️ 6359995 #6 2023-09-19 11:33:32 ~1 min linux 📦deb
✔️ 6359995 #6 2023-09-19 11:34:42 ~2 min tests 📄log
✔️ 6359995 #6 2023-09-19 11:35:57 ~3 min android 📦tgz
✔️ 6359995 #6 2023-09-19 11:36:44 ~4 min tests 📄log
✔️ 6359995 #6 2023-09-19 11:36:51 ~4 min ios 📦tgz
✔️ ff3bd3c #7 2023-09-19 11:37:48 ~58 sec tests 📄log
✔️ ff3bd3c #7 2023-09-19 11:38:17 ~3 min nix-flake 📄log
✔️ ff3bd3c #7 2023-09-19 11:38:22 ~3 min linux 📦deb
✔️ ff3bd3c #7 2023-09-19 11:39:10 ~4 min ios 📦tgz
✔️ ff3bd3c #7 2023-09-19 11:39:18 ~4 min tests 📄log
✔️ ff3bd3c #7 2023-09-19 11:40:48 ~4 min android 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ f39ded7 #8 2023-09-19 11:39:45 ~28 sec nix-flake 📄log
✔️ f39ded7 #8 2023-09-19 11:40:19 ~1 min linux 📦deb
✔️ f39ded7 #8 2023-09-19 11:42:16 ~2 min tests 📄log
✔️ f39ded7 #8 2023-09-19 11:42:26 ~3 min tests 📄log
✔️ f39ded7 #8 2023-09-19 11:42:48 ~3 min ios 📦tgz
✔️ 91f1ac0 #9 2023-09-19 11:43:49 ~2 min linux 📦deb
✔️ 91f1ac0 #9 2023-09-19 11:44:56 ~3 min nix-flake 📄log
✔️ 91f1ac0 #9 2023-09-19 11:45:20 ~3 min ios 📦tgz
✔️ 91f1ac0 #9 2023-09-19 11:45:45 ~3 min tests 📄log
✔️ 91f1ac0 #9 2023-09-19 11:46:19 ~3 min tests 📄log
✔️ 91f1ac0 #9 2023-09-19 11:49:03 ~6 min android 📦tgz

@vitvly vitvly force-pushed the refactor/filter-client-subs branch 4 times, most recently from 9a04cb9 to 4e89483 Compare September 18, 2023 11:16
@vitvly vitvly self-assigned this Sep 18, 2023
richard-ramos
richard-ramos approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@richard-ramos richard-ramos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool PR 🚀
Thanks also for the renames to make clear whether we're using a pubsubTopic or contentTopic

waku/v2/protocol/filter/client.go Outdated Show resolved Hide resolved
@richard-ramos richard-ramos changed the title Topic refactors for filter client feat: topic refactors for filter client Sep 18, 2023
@richard-ramos
Copy link
Member

jenkins/prs/nix-flake is failing. This needs to be updated https://github.com/waku-org/go-waku/blob/master/flake.nix#L32

@vitvly vitvly mentioned this pull request Sep 18, 2023
Closed
chaitanyaprem
chaitanyaprem approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just a minor comment.

waku/v2/protocol/filter/client.go Show resolved Hide resolved
@vitvly vitvly force-pushed the refactor/filter-client-subs branch 2 times, most recently from ff3bd3c to f39ded7 Compare September 19, 2023 11:39
@vitvly vitvly force-pushed the refactor/filter-client-subs branch from f39ded7 to 91f1ac0 Compare September 19, 2023 11:41
@vitvly
Copy link
Contributor Author

vitvly commented Sep 19, 2023

@richard-ramos fixed Nix build

@chaitanyaprem chaitanyaprem merged commit 81638fe into master Sep 19, 2023
@chaitanyaprem chaitanyaprem deleted the refactor/filter-client-subs branch September 19, 2023 12:52
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@richard-ramos richard-ramos richard-ramos approved these changes

@harsh-98 harsh-98 Awaiting requested review from harsh-98

Assignees

@vitvly vitvly

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitvly @status-im-auto @richard-ramos @chaitanyaprem