feat: force unreachability #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
requested review from
chaitanyaprem,
harsh-98 and
danisharora099
Jenkins BuildsClick to see older builds (6)
|
richard-ramos
force-pushed
the
unreachable
branch
from
019824f to
42a1d55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a hidden
--force-unreachableflag that will force the node to use circuit relay. After some seconds the node will have negotiated a circuit relay address if a circuit relay node is added as static node:While testing the functionality with @danisharora099 we noticed that when using an nwaku fleet node, and having wss enabled, the node gets dropped as a peer hence for now I recommend using a node from the gowaku fleet, however the gowaku fleet is returning IP addresses in the list of multiaddresses, so a search/replace must be done to replace the /ip4 address returned by a /dns4 value
This PR also fixes an issue with adding pubsub topics to the peer store that happens when adding a peer for the first time, and changes the TTL for addresses being added to the store since addresses with a ConnectedAddrTTL still had a chance of being removed by identify