Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add ws to enr #768

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix: add ws to enr #768

merged 2 commits into from
Oct 17, 2023

Conversation

richard-ramos
Copy link
Member

Description

Adds ws addresses to the ENR instead of only wss

@status-im-auto
Copy link

status-im-auto commented Sep 22, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (30)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 52353ee #1 2023-09-22 14:51:51 ~2 min nix-flake 📄log
✖️ 52353ee #1 2023-09-22 14:52:05 ~2 min tests 📄log
✔️ 52353ee #1 2023-09-22 14:52:08 ~2 min linux 📦deb
✖️ 52353ee #1 2023-09-22 14:52:41 ~3 min tests 📄log
✔️ 52353ee #1 2023-09-22 14:53:21 ~3 min android 📦tgz
✔️ 52353ee #1 2023-09-22 14:53:31 ~3 min ios 📦tgz
✔️ e9be004 #2 2023-09-24 20:56:27 ~1 min nix-flake 📄log
✔️ e9be004 #2 2023-09-24 20:56:52 ~2 min linux 📦deb
✔️ e9be004 #2 2023-09-24 20:57:29 ~2 min tests 📄log
✔️ e9be004 #2 2023-09-24 20:57:36 ~2 min tests 📄log
✔️ e9be004 #2 2023-09-24 20:58:13 ~3 min android 📦tgz
✔️ e9be004 #2 2023-09-24 20:58:40 ~4 min ios 📦tgz
✔️ 93c6e7f #3 2023-09-27 06:50:53 ~1 min linux 📦deb
✔️ 93c6e7f #3 2023-09-27 06:51:40 ~1 min nix-flake 📄log
✔️ 93c6e7f #3 2023-09-27 06:51:55 ~2 min tests 📄log
✔️ 93c6e7f #3 2023-09-27 06:52:56 ~3 min tests 📄log
✔️ 93c6e7f #3 2023-09-27 06:53:21 ~3 min android 📦tgz
✔️ 93c6e7f #3 2023-09-27 06:53:27 ~3 min ios 📦tgz
✔️ 65aa242 #4 2023-10-02 19:22:33 ~1 min tests 📄log
✔️ 65aa242 #4 2023-10-02 19:22:42 ~1 min linux 📦deb
✔️ 65aa242 #4 2023-10-02 19:22:53 ~1 min nix-flake 📄log
✖️ 65aa242 #4 2023-10-02 19:23:26 ~2 min tests 📄log
✔️ 65aa242 #4 2023-10-02 19:24:54 ~3 min android 📦tgz
✔️ 65aa242 #4 2023-10-02 19:25:52 ~4 min ios 📦tgz
✔️ a467ec6 #5 2023-10-16 15:48:44 ~1 min linux 📦deb
✔️ a467ec6 #5 2023-10-16 15:48:55 ~2 min nix-flake 📄log
✖️ a467ec6 #5 2023-10-16 15:49:32 ~2 min tests 📄log
✖️ a467ec6 #5 2023-10-16 15:52:42 ~5 min tests 📄log
✔️ a467ec6 #5 2023-10-16 15:53:05 ~6 min android 📦tgz
✔️ a467ec6 #5 2023-10-16 15:53:50 ~7 min ios 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 66577db #6 2023-10-16 15:59:57 ~1 min linux 📦deb
✔️ 66577db #6 2023-10-16 16:00:26 ~1 min tests 📄log
✔️ 66577db #6 2023-10-16 16:01:13 ~2 min nix-flake 📄log
✔️ 66577db #6 2023-10-16 16:02:07 ~3 min android 📦tgz
✔️ 66577db #6 2023-10-16 16:02:21 ~3 min tests 📄log
✔️ 66577db #6 2023-10-16 16:04:40 ~5 min ios 📦tgz
✔️ 71b6c5c #7 2023-10-17 11:45:53 ~1 min linux 📦deb
✔️ 71b6c5c #7 2023-10-17 11:46:31 ~1 min tests 📄log
✔️ 71b6c5c #7 2023-10-17 11:46:39 ~2 min nix-flake 📄log
✔️ 71b6c5c #7 2023-10-17 11:47:07 ~2 min tests 📄log
✔️ 71b6c5c #7 2023-10-17 11:48:00 ~3 min android 📦tgz
✔️ 71b6c5c #7 2023-10-17 11:48:40 ~4 min ios 📦tgz

chaitanyaprem
chaitanyaprem approved these changes Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment though.

waku/v2/node/localnode.go Show resolved Hide resolved
@richard-ramos richard-ramos merged commit ee94581 into master Oct 17, 2023
2 checks passed
@richard-ramos richard-ramos deleted the fix/enr-wss branch October 17, 2023 12:29
@danisharora099 danisharora099 mentioned this pull request Oct 18, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@harsh-98 harsh-98 harsh-98 approved these changes

@danisharora099 danisharora099 Awaiting requested review from danisharora099

Assignees
No one assigned
Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richard-ramos @status-im-auto @chaitanyaprem @harsh-98