Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: metadata protocol #805

Merged
merged 3 commits into from
Oct 21, 2023
Merged

feat: metadata protocol #805

merged 3 commits into from
Oct 21, 2023

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Oct 15, 2023 •
edited
Loading

Description

WakuMetadataProtocol implementation and tests

Issue

closes #799

@status-im-auto
Copy link

status-im-auto commented Oct 15, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (79)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 0330005 #1 2023-10-15 19:19:07 ~1 min nix-flake 📄log
❌ 0330005 #1 2023-10-15 19:19:14 ~1 min linux 📄log
✖️ 0330005 #1 2023-10-15 19:19:29 ~1 min tests 📄log
✖️ 0330005 #1 2023-10-15 19:19:41 ~1 min tests 📄log
❌ 0330005 #1 2023-10-15 19:20:59 ~3 min android 📄log
❌ 0330005 #1 2023-10-15 19:21:44 ~3 min ios 📄log
✔️ f9a7c29 #2 2023-10-17 16:08:16 ~1 min nix-flake 📄log
✔️ f9a7c29 #2 2023-10-17 16:08:46 ~2 min linux 📦deb
✔️ f9a7c29 #2 2023-10-17 16:09:59 ~3 min tests 📄log
✔️ f9a7c29 #2 2023-10-17 16:10:11 ~3 min tests 📄log
✔️ f9a7c29 #2 2023-10-17 16:10:39 ~4 min ios 📦tgz
✔️ 4a0b3a8 #3 2023-10-17 16:26:57 ~2 min nix-flake 📄log
✔️ 4a0b3a8 #3 2023-10-17 16:27:16 ~2 min linux 📦deb
✔️ 4a0b3a8 #3 2023-10-17 16:28:38 ~3 min ios 📦tgz
✔️ 4a0b3a8 #3 2023-10-17 16:29:54 ~5 min tests 📄log
✔️ 4a0b3a8 #3 2023-10-17 16:30:36 ~5 min android 📦tgz
✖️ 4a0b3a8 #3 2023-10-17 16:32:57 ~8 min tests 📄log
✖️ 1bf8537 #4 2023-10-17 19:40:21 ~24 sec tests 📄log
✖️ 1bf8537 #4 2023-10-17 19:41:27 ~1 min tests 📄log
✔️ 1bf8537 #4 2023-10-17 19:41:58 ~2 min nix-flake 📄log
✔️ 1bf8537 #4 2023-10-17 19:42:21 ~2 min linux 📦deb
✔️ 1bf8537 #4 2023-10-17 19:43:34 ~3 min android 📦tgz
✔️ 1bf8537 #4 2023-10-17 19:43:35 ~3 min ios 📦tgz
✖️ 7961eb1 #5 2023-10-17 19:42:28 ~1 min tests 📄log
✔️ 7961eb1 #5 2023-10-17 19:43:29 ~1 min linux 📦deb
✔️ 7961eb1 #5 2023-10-17 19:43:53 ~2 min tests 📄log
✔️ 7961eb1 #5 2023-10-17 19:44:00 ~1 min nix-flake 📄log
✔️ 7961eb1 #5 2023-10-17 19:45:58 ~4 min ios 📦tgz
✔️ 7961eb1 #5 2023-10-17 19:46:59 ~3 min android 📦tgz
✖️ b018a35 #6 2023-10-19 15:44:31 ~59 sec tests 📄log
✖️ b018a35 #6 2023-10-19 15:44:51 ~1 min tests 📄log
✔️ b018a35 #6 2023-10-19 15:45:10 ~1 min linux 📦deb
✔️ b018a35 #6 2023-10-19 15:47:49 ~4 min nix-flake 📄log
✔️ b018a35 #6 2023-10-19 15:48:07 ~4 min android 📦tgz
✔️ b018a35 #6 2023-10-19 15:48:56 ~5 min ios 📦tgz
✔️ a7b2606 #7 2023-10-19 15:46:53 ~1 min linux 📦deb
✔️ a7b2606 #7 2023-10-19 15:47:59 ~2 min tests 📄log
✔️ a7b2606 #7 2023-10-19 15:48:38 ~2 min tests 📄log
✔️ a7b2606 #7 2023-10-19 15:49:45 ~1 min nix-flake 📄log
✔️ a7b2606 #7 2023-10-19 15:53:38 ~5 min android 📦tgz
✔️ a7b2606 #7 2023-10-19 15:53:49 ~8 min ios 📦tgz
✔️ 762ae12 #8 2023-10-19 23:58:17 ~1 min linux 📦deb
✖️ 762ae12 #8 2023-10-19 23:58:29 ~1 min tests 📄log
✔️ 762ae12 #8 2023-10-19 23:59:04 ~1 min nix-flake 📄log
✔️ 762ae12 #8 2023-10-19 23:59:28 ~2 min tests 📄log
✔️ 762ae12 #8 2023-10-20 00:01:38 ~4 min ios 📦tgz
✔️ 762ae12 #8 2023-10-20 00:01:53 ~4 min android 📦tgz
✔️ 762ae12 #9 2023-10-20 00:04:18 ~2 min tests 📄log
✔️ bcdb3f4 #9 2023-10-20 20:27:51 ~1 min linux 📦deb
✔️ bcdb3f4 #9 2023-10-20 20:28:39 ~1 min nix-flake 📄log
✔️ bcdb3f4 #10 2023-10-20 20:28:39 ~1 min tests 📄log
✔️ bcdb3f4 #9 2023-10-20 20:30:08 ~3 min tests 📄log
✔️ bcdb3f4 #9 2023-10-20 20:30:29 ~3 min android 📦tgz
✔️ bcdb3f4 #9 2023-10-20 20:30:37 ~3 min ios 📦tgz
✔️ ad3a17e #10 2023-10-20 21:26:07 ~1 min linux 📦deb
✔️ ad3a17e #10 2023-10-20 21:26:57 ~1 min nix-flake 📄log
✔️ ad3a17e #10 2023-10-20 21:27:16 ~2 min tests 📄log
✔️ ad3a17e #10 2023-10-20 21:28:33 ~3 min ios 📦tgz
✔️ ad3a17e #10 2023-10-20 21:28:38 ~3 min android 📦tgz
✔️ ad3a17e #11 2023-10-20 21:28:39 ~3 min tests 📄log
✔️ 955abc6 #11 2023-10-21 00:10:59 ~1 min linux 📦deb
✔️ 955abc6 #12 2023-10-21 00:11:30 ~1 min tests 📄log
✔️ 955abc6 #11 2023-10-21 00:11:44 ~1 min nix-flake 📄log
✔️ 955abc6 #11 2023-10-21 00:12:06 ~2 min tests 📄log
✔️ 955abc6 #11 2023-10-21 00:13:29 ~3 min android 📦tgz
✔️ 955abc6 #11 2023-10-21 00:13:56 ~4 min ios 📦tgz
✔️ e92b9c0 #12 2023-10-21 00:18:08 ~1 min linux 📦deb
✔️ e92b9c0 #13 2023-10-21 00:18:41 ~1 min tests 📄log
✔️ e92b9c0 #12 2023-10-21 00:18:55 ~1 min nix-flake 📄log
✔️ e92b9c0 #12 2023-10-21 00:19:16 ~2 min tests 📄log
✔️ e92b9c0 #12 2023-10-21 00:20:17 ~3 min android 📦tgz
✔️ e92b9c0 #12 2023-10-21 00:20:40 ~3 min ios 📦tgz
✔️ 17c8b03 #13 2023-10-21 00:19:20 ~59 sec linux 📦deb
✔️ 17c8b03 #14 2023-10-21 00:20:01 ~1 min tests 📄log
✔️ 17c8b03 #13 2023-10-21 00:22:30 ~4 min ios 📦tgz
✔️ 03de74d #14 2023-10-21 00:20:25 ~1 min linux 📦deb
✔️ 03de74d #13 2023-10-21 00:20:52 ~1 min nix-flake 📄log
✔️ 03de74d #13 2023-10-21 00:22:37 ~3 min tests 📄log
✔️ 03de74d #14 2023-10-21 00:23:49 ~4 min ios 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7110e08 #15 2023-10-21 00:21:41 ~1 min linux 📦deb
✔️ 7110e08 #15 2023-10-21 00:21:59 ~1 min tests 📄log
✔️ 7110e08 #13 2023-10-21 00:23:40 ~3 min android 📦tgz
✔️ 7110e08 #15 2023-10-21 00:25:06 ~5 min ios 📦tgz
✔️ c975ce8 #14 2023-10-21 00:22:46 ~1 min nix-flake 📄log
✔️ c975ce8 #16 2023-10-21 00:23:09 ~1 min tests 📄log
✖️ c975ce8 #14 2023-10-21 00:23:45 ~1 min tests 📄log
✔️ c975ce8 #16 2023-10-21 00:24:06 ~2 min linux 📦deb
✔️ c975ce8 #16 2023-10-21 00:24:37 ~3 min ios 📦tgz
✔️ c975ce8 #14 2023-10-21 00:27:21 ~3 min android 📦tgz
✔️ c975ce8 #15 2023-10-21 00:27:54 ~2 min tests 📄log

@harsh-98
Copy link
Contributor

Add alvaro to this PR, once it is up for reviews. Discussed in monday PM meet.

@richard-ramos richard-ramos force-pushed the metadata branch 4 times, most recently from 1bf8537 to 7961eb1 Compare October 17, 2023 19:41
@richard-ramos richard-ramos marked this pull request as ready for review October 17, 2023 19:42
@richard-ramos richard-ramos force-pushed the metadata branch 2 times, most recently from b018a35 to a7b2606 Compare October 19, 2023 15:45
chaitanyaprem
chaitanyaprem reviewed Oct 19, 2023
View reviewed changes
waku/v2/node/wakunode2.go Outdated Show resolved Hide resolved
waku/v2/peermanager/topic_event_handler.go Outdated Show resolved Hide resolved
@richard-ramos richard-ramos force-pushed the metadata branch 3 times, most recently from e92b9c0 to 17c8b03 Compare October 21, 2023 00:18
chaitanyaprem
chaitanyaprem approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit 9161c4f into master Oct 21, 2023
2 checks passed
@richard-ramos richard-ramos deleted the metadata branch October 21, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alrevuelta alrevuelta alrevuelta left review comments

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@harsh-98 harsh-98 Awaiting requested review from harsh-98

Assignees
No one assigned
Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add new metadata protocol
5 participants
@richard-ramos @status-im-auto @harsh-98 @alrevuelta @chaitanyaprem