-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: addr update #806
fix: addr update #806
Conversation
Jenkins BuildsClick to see older builds (12)
|
dde1138
to
399af41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Did you face some challenge with Math.Rand and hence moved to crypto rand?
Would be nice to know the reasons for the switch.
I changed it due to a deprecation warning from the IDE: https://tip.golang.org/doc/go1.20
|
399af41
to
5137796
Compare
5137796
to
fb2959c
Compare
Description
Simplifies the code for verifying if there was an update in the listening addresses, and also does the verification regardless of the order of the addresses returned by ListenAddresses()
The reason for this change is that I noticed a case when I received a listenAdd update, containing the same addresses as before, but the order was different.
Also updates the go version to 1.20 (to match go-libp2p)